diff mbox

[RESEND] dpt_i2o: fix build warning

Message ID 1455784153-9615-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Sudip Mukherjee Feb. 18, 2016, 8:29 a.m. UTC 
We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not used

dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not
defined then dptids[] becomes unused.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

Resending v1 as v2 had a NACK from Alan about the spec not maintained
while converting to pci driver.

 drivers/scsi/dpt_i2o.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Martin K. Petersen Feb. 23, 2016, 10:44 p.m. UTC | #1 
>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

Sudip> We were getting build warning about:
Sudip> drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not
Sudip> used

Sudip> dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE
Sudip> is not defined then dptids[] becomes unused.

Applied to 4.6/scsi-queue.
diff mbox

Patch

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index d4cda5e..21c8d21 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -180,11 +180,14 @@  static u8 adpt_read_blink_led(adpt_hba* host)
  *============================================================================
  */
 
+#ifdef MODULE
 static struct pci_device_id dptids[] = {
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ 0, }
 };
+#endif
+
 MODULE_DEVICE_TABLE(pci,dptids);
 
 static int adpt_detect(struct scsi_host_template* sht)