Message ID | 1456280542-13113-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Simon, Thank you for the patch. On Wednesday 24 February 2016 11:22:22 Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Based on media_tree/master > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 201f5c296a95..662c029400de 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -37,7 +37,7 @@ config VIDEO_SH_VOU > tristate "SuperH VOU video output driver" > depends on MEDIA_CAMERA_SUPPORT > depends on VIDEO_DEV && I2C && HAS_DMA > - depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on ARCH_RENESAS || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > help > Support for the Video Output Unit (VOU) on SuperH SoCs. > @@ -238,7 +238,7 @@ config VIDEO_SH_VEU > config VIDEO_RENESAS_JPU > tristate "Renesas JPEG Processing Unit" > depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA > - depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on ARCH_RENESAS || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > ---help--- > @@ -250,7 +250,7 @@ config VIDEO_RENESAS_JPU > config VIDEO_RENESAS_VSP1 > tristate "Renesas VSP1 Video Processing Engine" > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA > - depends on (ARCH_SHMOBILE && OF) || COMPILE_TEST > + depends on (ARCH_RENESAS && OF) || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > ---help--- > This is a V4L2 driver for the Renesas VSP1 video processing engine.
Hi Simon, On Wed, Feb 24, 2016 at 3:22 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > drivers/media/platform/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Based on media_tree/master > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 201f5c296a95..662c029400de 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -37,7 +37,7 @@ config VIDEO_SH_VOU > tristate "SuperH VOU video output driver" > depends on MEDIA_CAMERA_SUPPORT > depends on VIDEO_DEV && I2C && HAS_DMA > - depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on ARCH_RENESAS || COMPILE_TEST This driver is used on sh7722/sh7723/sh7724 only. While these are Renesas parts, ARCH_RENESAS isn't set for SuperH SoCs, making this driver unavailable where needed. > select VIDEOBUF2_DMA_CONTIG > help > Support for the Video Output Unit (VOU) on SuperH SoCs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 24, 2016 at 08:46:31AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Feb 24, 2016 at 3:22 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > drivers/media/platform/Kconfig | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Based on media_tree/master > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 201f5c296a95..662c029400de 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -37,7 +37,7 @@ config VIDEO_SH_VOU > > tristate "SuperH VOU video output driver" > > depends on MEDIA_CAMERA_SUPPORT > > depends on VIDEO_DEV && I2C && HAS_DMA > > - depends on ARCH_SHMOBILE || COMPILE_TEST > > + depends on ARCH_RENESAS || COMPILE_TEST > > This driver is used on sh7722/sh7723/sh7724 only. > While these are Renesas parts, ARCH_RENESAS isn't set for SuperH SoCs, > making this driver unavailable where needed. Thanks for pointing that out, I had missed that detail. Ideally I would like to stop setting ARCH_SHMOBILE for ARM Based SoCs. So perhaps the following would be best? depends on ARCH_SHMOBILE || ARCH_RENESAS || COMPILE_TEST > > select VIDEOBUF2_DMA_CONTIG > > help > > Support for the Video Output Unit (VOU) on SuperH SoCs. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 25, 2016 at 08:56:22AM +0900, Simon Horman wrote: > On Wed, Feb 24, 2016 at 08:46:31AM +0100, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Wed, Feb 24, 2016 at 3:22 AM, Simon Horman > > <horms+renesas@verge.net.au> wrote: > > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > > > > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > > drivers/media/platform/Kconfig | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > Based on media_tree/master > > > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > > index 201f5c296a95..662c029400de 100644 > > > --- a/drivers/media/platform/Kconfig > > > +++ b/drivers/media/platform/Kconfig > > > @@ -37,7 +37,7 @@ config VIDEO_SH_VOU > > > tristate "SuperH VOU video output driver" > > > depends on MEDIA_CAMERA_SUPPORT > > > depends on VIDEO_DEV && I2C && HAS_DMA > > > - depends on ARCH_SHMOBILE || COMPILE_TEST > > > + depends on ARCH_RENESAS || COMPILE_TEST > > > > This driver is used on sh7722/sh7723/sh7724 only. > > While these are Renesas parts, ARCH_RENESAS isn't set for SuperH SoCs, > > making this driver unavailable where needed. > > Thanks for pointing that out, I had missed that detail. > > Ideally I would like to stop setting ARCH_SHMOBILE for ARM Based > SoCs. So perhaps the following would be best? > > depends on ARCH_SHMOBILE || ARCH_RENESAS || COMPILE_TEST Sorry, I think I misread your comment. If the driver is not used by any ARM Based SoCs then perhaps this patch should be simply withdrawn. > > > select VIDEOBUF2_DMA_CONTIG > > > help > > > Support for the Video Output Unit (VOU) on SuperH SoCs. > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Thu, Feb 25, 2016 at 1:32 AM, Simon Horman <horms@verge.net.au> wrote: > On Thu, Feb 25, 2016 at 08:56:22AM +0900, Simon Horman wrote: >> On Wed, Feb 24, 2016 at 08:46:31AM +0100, Geert Uytterhoeven wrote: >> > On Wed, Feb 24, 2016 at 3:22 AM, Simon Horman >> > <horms+renesas@verge.net.au> wrote: >> > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. >> > > >> > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to >> > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more >> > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. >> > > >> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> > > --- >> > > drivers/media/platform/Kconfig | 6 +++--- >> > > 1 file changed, 3 insertions(+), 3 deletions(-) >> > > >> > > Based on media_tree/master >> > > >> > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> > > index 201f5c296a95..662c029400de 100644 >> > > --- a/drivers/media/platform/Kconfig >> > > +++ b/drivers/media/platform/Kconfig >> > > @@ -37,7 +37,7 @@ config VIDEO_SH_VOU >> > > tristate "SuperH VOU video output driver" >> > > depends on MEDIA_CAMERA_SUPPORT >> > > depends on VIDEO_DEV && I2C && HAS_DMA >> > > - depends on ARCH_SHMOBILE || COMPILE_TEST >> > > + depends on ARCH_RENESAS || COMPILE_TEST >> > >> > This driver is used on sh7722/sh7723/sh7724 only. >> > While these are Renesas parts, ARCH_RENESAS isn't set for SuperH SoCs, >> > making this driver unavailable where needed. >> >> Thanks for pointing that out, I had missed that detail. >> >> Ideally I would like to stop setting ARCH_SHMOBILE for ARM Based >> SoCs. So perhaps the following would be best? >> >> depends on ARCH_SHMOBILE || ARCH_RENESAS || COMPILE_TEST > > Sorry, I think I misread your comment. If the driver is not > used by any ARM Based SoCs then perhaps this patch should be simply > withdrawn. Just the first chunk. If you drop that one, you can have my Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 201f5c296a95..662c029400de 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -37,7 +37,7 @@ config VIDEO_SH_VOU tristate "SuperH VOU video output driver" depends on MEDIA_CAMERA_SUPPORT depends on VIDEO_DEV && I2C && HAS_DMA - depends on ARCH_SHMOBILE || COMPILE_TEST + depends on ARCH_RENESAS || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG help Support for the Video Output Unit (VOU) on SuperH SoCs. @@ -238,7 +238,7 @@ config VIDEO_SH_VEU config VIDEO_RENESAS_JPU tristate "Renesas JPEG Processing Unit" depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA - depends on ARCH_SHMOBILE || COMPILE_TEST + depends on ARCH_RENESAS || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV ---help--- @@ -250,7 +250,7 @@ config VIDEO_RENESAS_JPU config VIDEO_RENESAS_VSP1 tristate "Renesas VSP1 Video Processing Engine" depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA - depends on (ARCH_SHMOBILE && OF) || COMPILE_TEST + depends on (ARCH_RENESAS && OF) || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG ---help--- This is a V4L2 driver for the Renesas VSP1 video processing engine.
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- drivers/media/platform/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Based on media_tree/master