| Message ID | 1305742026.8771.26.camel@anish-desktop (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Wed, May 18, 2011 at 11:37:06PM +0530, anish wrote: > The preferred form for passing a size of a struct is the following: > p = kmalloc(sizeof(*p), ...); > Please refer Documentation/Codingstyle chapter 14 > > Signed-off-by: anish kumar <anish198519851985@gmail.com> > That's pretty subjective, and ultimately depends on the author. I personally prefer to have it written out, but then I don't randomly change my structure types around either, so the "bug" alluded to isn't really an issue. I'm not sure I buy the impaired readability argument, either.. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c index 5fc983c..cb7ec86 100644 --- a/drivers/video/amba-clcd.c +++ b/drivers/video/amba-clcd.c @@ -549,7 +549,7 @@ static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id) goto out; } - fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL); + fb = kzalloc(sizeof(*fb), GFP_KERNEL); if (!fb) { printk(KERN_INFO "CLCD: could not allocate new clcd_fb struct\n"); ret = -ENOMEM;
The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); Please refer Documentation/Codingstyle chapter 14 Signed-off-by: anish kumar <anish198519851985@gmail.com> --- drivers/video/amba-clcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)