diff mbox

[v17,5/6] davinci vpbe: Build infrastructure for VPBE driver

Message ID 1305899324-2118-1-git-send-email-manjunath.hadli@ti.com (mailing list archive)
State Awaiting Upstream
Headers show

Commit Message

Manjunath Hadli May 20, 2011, 1:48 p.m. UTC 
This patch adds the build infra-structure for Davinci
VPBE dislay driver.

Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Acked-by: Muralidharan Karicheri <m-karicheri2@ti.com>
Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
---
 drivers/media/video/davinci/Kconfig  |   22 ++++++++++++++++++++++
 drivers/media/video/davinci/Makefile |    2 ++
 2 files changed, 24 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov May 20, 2011, 2:32 p.m. UTC | #1 
Hello.

Manjunath Hadli wrote:

> This patch adds the build infra-structure for Davinci
> VPBE dislay driver.

> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> Acked-by: Muralidharan Karicheri <m-karicheri2@ti.com>
> Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
[...]

> diff --git a/drivers/media/video/davinci/Kconfig b/drivers/media/video/davinci/Kconfig
> index 6b19540..a7f11e7 100644
> --- a/drivers/media/video/davinci/Kconfig
> +++ b/drivers/media/video/davinci/Kconfig
> @@ -91,3 +91,25 @@ config VIDEO_ISIF
>  
>  	   To compile this driver as a module, choose M here: the
>  	   module will be called vpfe.
> +
> +config VIDEO_DM644X_VPBE
> +	tristate "DM644X VPBE HW module"

    BTW, as this seems DM644x specific, shouldn't this depend on 
CONFIG_ARCH_DAVINCI_DM644x?

> +	select VIDEO_VPSS_SYSTEM
> +	select VIDEOBUF_DMA_CONTIG
> +	help
> +	    Enables VPBE modules used for display on a DM644x
> +	    SoC.
> +
> +	    To compile this driver as a module, choose M here: the
> +	    module will be called vpbe.
> +
> +
> +config VIDEO_VPBE_DISPLAY
> +	tristate "VPBE V4L2 Display driver"
> +	select VIDEO_DM644X_VPBE

    Or this one, if it selects VIDEO_DM644X_VPBE?

> +	default y

    Hm, "y" shouldn't be the default.

WBR, Sergei
Sekhar Nori May 23, 2011, 8:28 a.m. UTC | #2 
On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote:
> Hello.
> 
> Manjunath Hadli wrote:
> 
> > This patch adds the build infra-structure for Davinci
> > VPBE dislay driver.
> 
> > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > Acked-by: Muralidharan Karicheri <m-karicheri2@ti.com>
> > Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> [...]
> 
> > diff --git a/drivers/media/video/davinci/Kconfig b/drivers/media/video/davinci/Kconfig
> > index 6b19540..a7f11e7 100644
> > --- a/drivers/media/video/davinci/Kconfig
> > +++ b/drivers/media/video/davinci/Kconfig
> > @@ -91,3 +91,25 @@ config VIDEO_ISIF
> >  
> >  	   To compile this driver as a module, choose M here: the
> >  	   module will be called vpfe.
> > +
> > +config VIDEO_DM644X_VPBE
> > +	tristate "DM644X VPBE HW module"
> 
>     BTW, as this seems DM644x specific, shouldn't this depend on 
> CONFIG_ARCH_DAVINCI_DM644x?

Since VENC/OSD etc are also applicable to other
DaVinci devices, this KConfig entry should probably
be split to refer to them individually and in a generic
way. "depends on" can then be used to make sure only
the relevant ones show up.

Thanks,
Sekhar
Manjunath Hadli May 24, 2011, 12:59 p.m. UTC | #3 
On Mon, May 23, 2011 at 13:58:26, Nori, Sekhar wrote:
> On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote:
> > Hello.
> > 
> > Manjunath Hadli wrote:
> > 
> > > This patch adds the build infra-structure for Davinci VPBE dislay 
> > > driver.
> > 
> > > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > > Acked-by: Muralidharan Karicheri <m-karicheri2@ti.com>
> > > Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> > [...]
> > 
> > > diff --git a/drivers/media/video/davinci/Kconfig 
> > > b/drivers/media/video/davinci/Kconfig
> > > index 6b19540..a7f11e7 100644
> > > --- a/drivers/media/video/davinci/Kconfig
> > > +++ b/drivers/media/video/davinci/Kconfig
> > > @@ -91,3 +91,25 @@ config VIDEO_ISIF
> > >  
> > >  	   To compile this driver as a module, choose M here: the
> > >  	   module will be called vpfe.
> > > +
> > > +config VIDEO_DM644X_VPBE
> > > +	tristate "DM644X VPBE HW module"
> > 
> >     BTW, as this seems DM644x specific, shouldn't this depend on 
> > CONFIG_ARCH_DAVINCI_DM644x?
> 
> Since VENC/OSD etc are also applicable to other DaVinci devices, this KConfig entry should probably be split to refer to them individually and in a generic way. "depends on" can then be used to make sure only the relevant ones show up.

Both venc and osd have to be used together always, so might not make a good idea to split. However, I will add a dependency on DM644x, and include others with appropriate patch sets.

> 
> Thanks,
> Sekhar
> 
>
diff mbox

Patch

diff --git a/drivers/media/video/davinci/Kconfig b/drivers/media/video/davinci/Kconfig
index 6b19540..a7f11e7 100644
--- a/drivers/media/video/davinci/Kconfig
+++ b/drivers/media/video/davinci/Kconfig
@@ -91,3 +91,25 @@  config VIDEO_ISIF
 
 	   To compile this driver as a module, choose M here: the
 	   module will be called vpfe.
+
+config VIDEO_DM644X_VPBE
+	tristate "DM644X VPBE HW module"
+	select VIDEO_VPSS_SYSTEM
+	select VIDEOBUF_DMA_CONTIG
+	help
+	    Enables VPBE modules used for display on a DM644x
+	    SoC.
+
+	    To compile this driver as a module, choose M here: the
+	    module will be called vpbe.
+
+
+config VIDEO_VPBE_DISPLAY
+	tristate "VPBE V4L2 Display driver"
+	select VIDEO_DM644X_VPBE
+	default y
+	help
+	    Enables VPBE V4L2 Display driver on a DMXXX device
+
+	    To compile this driver as a module, choose M here: the
+	    module will be called vpbe_display.
diff --git a/drivers/media/video/davinci/Makefile b/drivers/media/video/davinci/Makefile
index a379557..ae7dafb 100644
--- a/drivers/media/video/davinci/Makefile
+++ b/drivers/media/video/davinci/Makefile
@@ -16,3 +16,5 @@  obj-$(CONFIG_VIDEO_VPFE_CAPTURE) += vpfe_capture.o
 obj-$(CONFIG_VIDEO_DM6446_CCDC) += dm644x_ccdc.o
 obj-$(CONFIG_VIDEO_DM355_CCDC) += dm355_ccdc.o
 obj-$(CONFIG_VIDEO_ISIF) += isif.o
+obj-$(CONFIG_VIDEO_DM644X_VPBE) += vpbe.o vpbe_osd.o vpbe_venc.o
+obj-$(CONFIG_VIDEO_VPBE_DISPLAY) += vpbe_display.o