[ANNOUNCE] util-linux v2.28-rc1

Commit Message

Samuel Thibault March 13, 2016, 8:32 p.m. UTC

Hello,

2.28-rc1 doesn't build on the Hurd system, see attached proposed patch.

sigset_t is not a structure on Hurd. Applications are not supposed to
assume what it is, and the first thing that sulogin.c does on it is
sigemptyset already anyway.

Samuel

Comments

Karel Zak March 14, 2016, 12:22 p.m. UTC | #1

On Sun, Mar 13, 2016 at 09:32:24PM +0100, Samuel Thibault wrote:
> sigset_t is not a structure on Hurd. Applications are not supposed to
> assume what it is, and the first thing that sulogin.c does on it is
> sigemptyset already anyway

 OK, fixed.

    Karel

Patch

diff --git a/login-utils/sulogin.c b/login-utils/sulogin.c
index 643712f..43ca0d4 100644
--- a/login-utils/sulogin.c
+++ b/login-utils/sulogin.c
@@ -859,7 +863,7 @@  int main(int argc, char **argv)
 	struct passwd *pwd;
 	struct timespec sigwait = { .tv_sec = 0, .tv_nsec = 50000000 };
 	siginfo_t status = {};
-	sigset_t set = {};
+	sigset_t set;
 	int c, reconnect = 0;
 	int opt_e = 0;
 	int wait = 0;