[resend,for,CI,1/2] drm/i915: Remove unused variable in i915_gem_request_add_to_client

Commit Message

Tvrtko Ursulin March 17, 2016, 1:04 p.m. UTC

From: Tvrtko Ursulin <[e-mail]>

Signed-off-by: Tvrtko Ursulin <[e-mail]>
Reviewed-by: Chris Wilson <[e-mail]>
---
 drivers/gpu/drm/i915/i915_gem.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Tvrtko Ursulin March 18, 2016, 9:57 a.m. UTC | #1

On 18/03/16 07:03, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [resend,for,CI,1/2] drm/i915: Remove unused variable in i915_gem_request_add_to_client
> URL   : https://patchwork.freedesktop.org/series/4572/
> State : failure
>
> == Summary ==
>
> Series 4572v1 Series without cover letter
> http://patchwork.freedesktop.org/api/1.0/series/4572/revisions/1/mbox/
>
> Test gem_ringfill:
>          Subgroup basic-default-s3:
>                  dmesg-warn -> PASS       (skl-nuci5)
> Test gem_storedw_loop:
>          Subgroup basic-default:
>                  dmesg-warn -> PASS       (skl-nuci5)
> Test gem_sync:
>          Subgroup basic-all:
>                  pass       -> DMESG-WARN (skl-nuci5)

Still some HDA issues:

WARNING: CPU: 1 PID: 40 at sound/hda/hdac_i915.c:91 
snd_hdac_display_power+0xf1/0x110 [snd_hda_core]()

>          Subgroup basic-vebox:
>                  dmesg-warn -> PASS       (skl-nuci5)
> Test kms_flip:
>          Subgroup basic-flip-vs-wf_vblank:
>                  pass       -> FAIL       (hsw-brixbox)

Long standing unrelated: https://bugs.freedesktop.org/show_bug.cgi?id=94294

> Test kms_frontbuffer_tracking:
>          Subgroup basic:
>                  dmesg-warn -> PASS       (hsw-gt2)
> Test kms_pipe_crc_basic:
>          Subgroup read-crc-pipe-a-frame-sequence:
>                  dmesg-warn -> PASS       (hsw-gt2)
>          Subgroup suspend-read-crc-pipe-c:
>                  dmesg-warn -> PASS       (bsw-nuc-2)
>
> bdw-ultra        total:194  pass:172  dwarn:1   dfail:0   fail:0   skip:21
> bsw-nuc-2        total:194  pass:156  dwarn:1   dfail:0   fail:0   skip:37
> hsw-brixbox      total:194  pass:170  dwarn:1   dfail:0   fail:1   skip:22
> hsw-gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip:17
> ivb-t430s        total:194  pass:168  dwarn:1   dfail:0   fail:0   skip:25
> skl-i5k-2        total:194  pass:170  dwarn:1   dfail:0   fail:0   skip:23
> skl-i7k-2        total:194  pass:170  dwarn:1   dfail:0   fail:0   skip:23
> skl-nuci5        total:194  pass:181  dwarn:2   dfail:0   fail:0   skip:11
> snb-dellxps      total:14   pass:7    dwarn:0   dfail:0   fail:0   skip:6
>
> Results at /archive/results/CI_IGT_test/Patchwork_1633/
>
> 10e913a48ca36790da9b58bed8729598ea79ebdb drm-intel-nightly: 2016y-03m-17d-13h-22m-41s UTC integration manifest
> edf23f502a4661ae2f9a42622452bd032d9c4172 drm/i915: Use shorter route to dev_private where possible
> 7f2bb0d40a9bb0f20eb0ef15abafc3c9c33d820f drm/i915: Remove unused variable in i915_gem_request_add_to_client

Merged the two. Thanks for the review.

Regards,

Tvrtko

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 31652c1da761..9c4d9c186d91 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1370,7 +1370,6 @@  out:
 int i915_gem_request_add_to_client(struct drm_i915_gem_request *req,
 				   struct drm_file *file)
 {
-	struct drm_i915_private *dev_private;
 	struct drm_i915_file_private *file_priv;
 
 	WARN_ON(!req || !file || req->file_priv);
@@ -1381,7 +1380,6 @@  int i915_gem_request_add_to_client(struct drm_i915_gem_request *req,
 	if (req->file_priv)
 		return -EINVAL;
 
-	dev_private = req->engine->dev->dev_private;
 	file_priv = file->driver_priv;
 
 	spin_lock(&file_priv->mm.lock);