| Message ID | 1458310036-19252-2-git-send-email-hans.verkuil@cisco.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Mar 18, 2016 at 03:07:00PM +0100, Hans Verkuil wrote: > From: Kamil Debski <kamil@wypas.org> > > Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and > Exynos4x12 SoCs. These are required by the HDMI CEC device. > > Signed-off-by: Kamil Debski <kamil@wypas.org> > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 +++++++ > arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 +++++++ > 2 files changed, 14 insertions(+) Hi Hans, I see you have been carrying these three patches for a long time. Initially I thought that there are some dependencies... but maybe there are not? Can I take these Exynos DTS patches to samsung-soc? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/19/2016 03:50 AM, Krzysztof Kozlowski wrote: > On Fri, Mar 18, 2016 at 03:07:00PM +0100, Hans Verkuil wrote: >> From: Kamil Debski <kamil@wypas.org> >> >> Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and >> Exynos4x12 SoCs. These are required by the HDMI CEC device. >> >> Signed-off-by: Kamil Debski <kamil@wypas.org> >> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 +++++++ >> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 +++++++ >> 2 files changed, 14 insertions(+) > > Hi Hans, > > I see you have been carrying these three patches for a long time. > Initially I thought that there are some dependencies... but maybe there > are not? > > Can I take these Exynos DTS patches to samsung-soc? That would be very nice! BTW, it would be nice if someone from Samsung could try to improve the s5p CEC driver from this patch series. The problem is that it expects userspace to tell it the physical address, which is read from the EDID. But the HDMI driver in the kernel already knows this, so requiring userspace to handle this is not nice. Basically the CEC driver needs to know when a new EDID has been read and when the hotplug detect goes low (EDID has been lost). If someone who actually knows the HDMI code could provide me with a patch, then I can fix the CEC driver. I have an odroid to test with, so I can check the code. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19.03.2016 17:15, Hans Verkuil wrote: > On 03/19/2016 03:50 AM, Krzysztof Kozlowski wrote: >> On Fri, Mar 18, 2016 at 03:07:00PM +0100, Hans Verkuil wrote: >>> From: Kamil Debski <kamil@wypas.org> >>> >>> Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and >>> Exynos4x12 SoCs. These are required by the HDMI CEC device. >>> >>> Signed-off-by: Kamil Debski <kamil@wypas.org> >>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> >>> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 +++++++ >>> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 +++++++ >>> 2 files changed, 14 insertions(+) >> >> Hi Hans, >> >> I see you have been carrying these three patches for a long time. >> Initially I thought that there are some dependencies... but maybe there >> are not? >> >> Can I take these Exynos DTS patches to samsung-soc? > > That would be very nice! I'll apply them after merge window. > BTW, it would be nice if someone from Samsung could try to improve the s5p > CEC driver from this patch series. > > The problem is that it expects userspace to tell it the physical address, > which is read from the EDID. But the HDMI driver in the kernel already knows > this, so requiring userspace to handle this is not nice. > > Basically the CEC driver needs to know when a new EDID has been read and > when the hotplug detect goes low (EDID has been lost). > > If someone who actually knows the HDMI code could provide me with a patch, > then I can fix the CEC driver. I have an odroid to test with, so I can check > the code. Not quite my area of knowledge but I'll keep it in mind. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index a7c2128..9331c62 100644 --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi @@ -820,6 +820,13 @@ samsung,pin-pud = <1>; samsung,pin-drv = <0>; }; + + hdmi_cec: hdmi-cec { + samsung,pins = "gpx3-6"; + samsung,pin-function = <3>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; }; pinctrl@03860000 { diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index bac25c6..856b292 100644 --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi @@ -885,6 +885,13 @@ samsung,pin-pud = <0>; samsung,pin-drv = <0>; }; + + hdmi_cec: hdmi-cec { + samsung,pins = "gpx3-6"; + samsung,pin-function = <3>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; }; pinctrl_2: pinctrl@03860000 {