diff mbox

slirp: Fix memory leak on small incoming ipv4 packet

Message ID 1458603985-10009-1-git-send-email-samuel.thibault@ens-lyon.org (mailing list archive)
State New, archived
Headers show

Commit Message

Samuel Thibault March 21, 2016, 11:46 p.m. UTC 
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 slirp/ip_input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth March 22, 2016, 3:39 p.m. UTC | #1 
On 22.03.2016 00:46, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  slirp/ip_input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 12f173d..b464f6b 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
>  	DEBUG_ARG("m_len = %d", m->m_len);
>  
>  	if (m->m_len < sizeof (struct ip)) {
> -		return;
> +		goto bad;
>  	}
>  
>  	ip = mtod(m, struct ip *);
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox

Patch

diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 12f173d..b464f6b 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -85,7 +85,7 @@  ip_input(struct mbuf *m)
 	DEBUG_ARG("m_len = %d", m->m_len);
 
 	if (m->m_len < sizeof (struct ip)) {
-		return;
+		goto bad;
 	}
 
 	ip = mtod(m, struct ip *);