diff mbox

[v2,5/6] Documentation: DT: vdma: update binding doc for AXI CDMA

Message ID 1459101966-9932-2-git-send-email-appanad@xilinx.com (mailing list archive)
State Superseded
Headers show

Commit Message

Appana Durga Kedareswara rao March 27, 2016, 6:06 p.m. UTC
This patch updates the device-tree binding doc for
adding support for AXI CDMA.

Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
---> Modified commit message as suggested by Vinod.
---> Moved the patch to forward in the series as suggested by vinod.

 .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Comments

Soren Brinkmann March 27, 2016, 7:27 p.m. UTC | #1
On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> This patch updates the device-tree binding doc for
> adding support for AXI CDMA.
> 
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
> ---> Modified commit message as suggested by Vinod.
> ---> Moved the patch to forward in the series as suggested by vinod.
> 
>  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index 5841421..2b0c12b 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel or two channels.
>  If configured as two channels, one is to transmit to the device and another
>  is to receive from the device.
>  
> +Xilinx AXI CDMA engine, it does transfers between memory-mapped source
> +address and a memory-mapped destination address.
> +
>  Required properties:
> -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> +	      "xlnx,axi-cdma-1.00.a""
>  - #dma-cells: Should be <1>, see "dmas" property below
>  - reg: Should contain VDMA registers location and length.
>  - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
>  	} ;
>  } ;
>  
> +axi_cdma_0: axicdma@7e200000 {
> +       compatible = "xlnx,axi-cdma-1.00.a";
> +       #dma-cells = <1>;
> +       reg = < 0x7e200000 0x10000 >;
> +       xlnx,addrwidth = <0x20>;
> +       dma-channel@7e200000 {
> +               compatible = "xlnx,axi-dma-mm2s-channel";
> +               interrupts = < 0 55 4 >;
> +               xlnx,datawidth = <0x40>;
> +       } ;
> +} ;

As in the other patch, the node name should be 'dma-controller@...' and
the inconsistend spacing could be fixed.

Also, it seems this adds pretty much identical examples that just differ
in the compat string. Is that really needed?

	Sören

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Appana Durga Kedareswara rao March 28, 2016, 5:27 a.m. UTC | #2
SGkgU29yZW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU8O2cmVu
IEJyaW5rbWFubiBbbWFpbHRvOnNvcmVuLmJyaW5rbWFubkB4aWxpbnguY29tXQ0KPiBTZW50OiBN
b25kYXksIE1hcmNoIDI4LCAyMDE2IDEyOjU4IEFNDQo+IFRvOiBBcHBhbmEgRHVyZ2EgS2VkYXJl
c3dhcmEgUmFvDQo+IENjOiByb2JoK2R0QGtlcm5lbC5vcmc7IHBhd2VsLm1vbGxAYXJtLmNvbTsg
bWFyay5ydXRsYW5kQGFybS5jb207DQo+IGlqYytkZXZpY2V0cmVlQGhlbGxpb24ub3JnLnVrOyBn
YWxha0Bjb2RlYXVyb3JhLm9yZzsgTWljaGFsIFNpbWVrOw0KPiB2aW5vZC5rb3VsQGludGVsLmNv
bTsgZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tOyBBbnVyYWcgS3VtYXIgVnVsaXNoYTsgQXBwYW5h
DQo+IER1cmdhIEtlZGFyZXN3YXJhIFJhbzsgbW9yaXR6LmZpc2NoZXJAZXR0dXMuY29tOw0KPiBs
YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb207IGx1aXNAZGViZXRoZW5jb3VydC5jb207
IFNyaWthbnRoDQo+IFZlbXVsYTsgQW5pcnVkaGEgU2FyYW5naTsgZGV2aWNldHJlZUB2Z2VyLmtl
cm5lbC5vcmc7IGxpbnV4LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4
LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+IGRtYWVuZ2luZUB2Z2VyLmtlcm5lbC5vcmcNCj4g
U3ViamVjdDogUmU6IFtQQVRDSCB2MiA1LzZdIERvY3VtZW50YXRpb246IERUOiB2ZG1hOiB1cGRh
dGUgYmluZGluZyBkb2MgZm9yDQo+IEFYSSBDRE1BDQo+IA0KPiBPbiBTdW4sIDIwMTYtMDMtMjcg
YXQgMjM6MzY6MDYgKzA1MzAsIEtlZGFyZXN3YXJhIHJhbyBBcHBhbmEgd3JvdGU6DQo+ID4gVGhp
cyBwYXRjaCB1cGRhdGVzIHRoZSBkZXZpY2UtdHJlZSBiaW5kaW5nIGRvYyBmb3IgYWRkaW5nIHN1
cHBvcnQgZm9yDQo+ID4gQVhJIENETUEuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBLZWRhcmVz
d2FyYSByYW8gQXBwYW5hIDxhcHBhbmFkQHhpbGlueC5jb20+DQo+ID4gLS0tDQo+ID4gLS0tPiBN
b2RpZmllZCBjb21taXQgbWVzc2FnZSBhcyBzdWdnZXN0ZWQgYnkgVmlub2QuDQo+ID4gLS0tPiBN
b3ZlZCB0aGUgcGF0Y2ggdG8gZm9yd2FyZCBpbiB0aGUgc2VyaWVzIGFzIHN1Z2dlc3RlZCBieSB2
aW5vZC4NCj4gPg0KPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEveGlsaW54L3hpbGlu
eF92ZG1hLnR4dCAgICAgfCAxOA0KPiArKysrKysrKysrKysrKysrKy0NCj4gPiAgMSBmaWxlIGNo
YW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYgLS1n
aXQNCj4gPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEveGlsaW54L3hp
bGlueF92ZG1hLnR4dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rt
YS94aWxpbngveGlsaW54X3ZkbWEudHh0DQo+ID4gaW5kZXggNTg0MTQyMS4uMmIwYzEyYiAxMDA2
NDQNCj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3hpbGlu
eC94aWxpbnhfdmRtYS50eHQNCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu
ZGluZ3MvZG1hL3hpbGlueC94aWxpbnhfdmRtYS50eHQNCj4gPiBAQCAtOCw4ICs4LDEyIEBAIHRh
cmdldCBkZXZpY2VzLiBJdCBjYW4gYmUgY29uZmlndXJlZCB0byBoYXZlIG9uZSBjaGFubmVsDQo+
IG9yIHR3byBjaGFubmVscy4NCj4gPiAgSWYgY29uZmlndXJlZCBhcyB0d28gY2hhbm5lbHMsIG9u
ZSBpcyB0byB0cmFuc21pdCB0byB0aGUgZGV2aWNlIGFuZA0KPiA+IGFub3RoZXIgIGlzIHRvIHJl
Y2VpdmUgZnJvbSB0aGUgZGV2aWNlLg0KPiA+DQo+ID4gK1hpbGlueCBBWEkgQ0RNQSBlbmdpbmUs
IGl0IGRvZXMgdHJhbnNmZXJzIGJldHdlZW4gbWVtb3J5LW1hcHBlZA0KPiA+ICtzb3VyY2UgYWRk
cmVzcyBhbmQgYSBtZW1vcnktbWFwcGVkIGRlc3RpbmF0aW9uIGFkZHJlc3MuDQo+ID4gKw0KPiA+
ICBSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+IC0tIGNvbXBhdGlibGU6IFNob3VsZCBiZSAieGxu
eCxheGktdmRtYS0xLjAwLmEiIG9yICJ4bG54LGF4aS1kbWEtMS4wMC5hIg0KPiA+ICstIGNvbXBh
dGlibGU6IFNob3VsZCBiZSAieGxueCxheGktdmRtYS0xLjAwLmEiIG9yICJ4bG54LGF4aS1kbWEt
MS4wMC5hIiBvcg0KPiA+ICsJICAgICAgInhsbngsYXhpLWNkbWEtMS4wMC5hIiINCj4gPiAgLSAj
ZG1hLWNlbGxzOiBTaG91bGQgYmUgPDE+LCBzZWUgImRtYXMiIHByb3BlcnR5IGJlbG93DQo+ID4g
IC0gcmVnOiBTaG91bGQgY29udGFpbiBWRE1BIHJlZ2lzdGVycyBsb2NhdGlvbiBhbmQgbGVuZ3Ro
Lg0KPiA+ICAtIHhsbngsbnVtLWZzdG9yZXM6IFNob3VsZCBiZSB0aGUgbnVtYmVyIG9mIGZyYW1l
YnVmZmVycyBhcyBjb25maWd1cmVkIGluDQo+IGgvdy4NCj4gPiBAQCAtODAsNiArODQsMTggQEAg
YXhpX2RtYV8wOiBheGlkbWFANDA0MDAwMDAgew0KPiA+ICAJfSA7DQo+ID4gIH0gOw0KPiA+DQo+
ID4gK2F4aV9jZG1hXzA6IGF4aWNkbWFAN2UyMDAwMDAgew0KPiA+ICsgICAgICAgY29tcGF0aWJs
ZSA9ICJ4bG54LGF4aS1jZG1hLTEuMDAuYSI7DQo+ID4gKyAgICAgICAjZG1hLWNlbGxzID0gPDE+
Ow0KPiA+ICsgICAgICAgcmVnID0gPCAweDdlMjAwMDAwIDB4MTAwMDAgPjsNCj4gPiArICAgICAg
IHhsbngsYWRkcndpZHRoID0gPDB4MjA+Ow0KPiA+ICsgICAgICAgZG1hLWNoYW5uZWxAN2UyMDAw
MDAgew0KPiA+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInhsbngsYXhpLWRtYS1tbTJz
LWNoYW5uZWwiOw0KPiA+ICsgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0gPCAwIDU1IDQgPjsN
Cj4gPiArICAgICAgICAgICAgICAgeGxueCxkYXRhd2lkdGggPSA8MHg0MD47DQo+ID4gKyAgICAg
ICB9IDsNCj4gPiArfSA7DQo+IA0KPiBBcyBpbiB0aGUgb3RoZXIgcGF0Y2gsIHRoZSBub2RlIG5h
bWUgc2hvdWxkIGJlICdkbWEtY29udHJvbGxlckAuLi4nIGFuZCB0aGUNCj4gaW5jb25zaXN0ZW5k
IHNwYWNpbmcgY291bGQgYmUgZml4ZWQuDQoNCk9rIHdpbGwgZml4Li4uDQoNCj4gDQo+IEFsc28s
IGl0IHNlZW1zIHRoaXMgYWRkcyBwcmV0dHkgbXVjaCBpZGVudGljYWwgZXhhbXBsZXMgdGhhdCBq
dXN0IGRpZmZlciBpbiB0aGUNCj4gY29tcGF0IHN0cmluZy4gSXMgdGhhdCByZWFsbHkgbmVlZGVk
Pw0KDQpNb3N0IG9mIHRoZSBwcm9wZXJ0aWVzIGFyZSBzYW1lIGFjcm9zcyB0aGUgdGhyZWUgRE1B
J3MNCkZvciBBWEkgVkRNQSB0aGVyZSBhcmUgZmV3IHJlcXVpcmVkIHByb3BlcnRpZXMgdGhhdCBh
cmUgbm90IHJlcXVpcmVkIGZvciBBWEkgRE1BL0NETUEuDQpUaGF0J3Mgd2h5IGFkZGVkIGV4YW1w
bGUgZm9yIHRoZSBvdGhlciBJUCdzIGFzIHdlbGwgSSBtZWFuIGZvciBBWEkgRE1BIGFuZCBDRE1B
Lg0KDQpSZWdhcmRzLA0KS2VkYXIuDQoNCj4gDQo+IAlTw7ZyZW4NCg0K
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring March 28, 2016, 8:55 p.m. UTC | #3
On Mon, Mar 28, 2016 at 05:27:01AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Soren,
> 
> > -----Original Message-----
> > From: Sören Brinkmann [mailto:soren.brinkmann@xilinx.com]
> > Sent: Monday, March 28, 2016 12:58 AM
> > To: Appana Durga Kedareswara Rao
> > Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; Michal Simek;
> > vinod.koul@intel.com; dan.j.williams@intel.com; Anurag Kumar Vulisha; Appana
> > Durga Kedareswara Rao; moritz.fischer@ettus.com;
> > laurent.pinchart@ideasonboard.com; luis@debethencourt.com; Srikanth
> > Vemula; Anirudha Sarangi; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > dmaengine@vger.kernel.org
> > Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> > AXI CDMA
> > 
> > On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > > This patch updates the device-tree binding doc for adding support for
> > > AXI CDMA.
> > >
> > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> > > ---
> > > ---> Modified commit message as suggested by Vinod.
> > > ---> Moved the patch to forward in the series as suggested by vinod.
> > >
> > >  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18
> > +++++++++++++++++-
> > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > index 5841421..2b0c12b 100644
> > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel
> > or two channels.
> > >  If configured as two channels, one is to transmit to the device and
> > > another  is to receive from the device.
> > >
> > > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > > +source address and a memory-mapped destination address.
> > > +
> > >  Required properties:
> > > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> > > +	      "xlnx,axi-cdma-1.00.a""
> > >  - #dma-cells: Should be <1>, see "dmas" property below
> > >  - reg: Should contain VDMA registers location and length.
> > >  - xlnx,num-fstores: Should be the number of framebuffers as configured in
> > h/w.
> > > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> > >  	} ;
> > >  } ;
> > >
> > > +axi_cdma_0: axicdma@7e200000 {
> > > +       compatible = "xlnx,axi-cdma-1.00.a";
> > > +       #dma-cells = <1>;
> > > +       reg = < 0x7e200000 0x10000 >;
> > > +       xlnx,addrwidth = <0x20>;
> > > +       dma-channel@7e200000 {
> > > +               compatible = "xlnx,axi-dma-mm2s-channel";
> > > +               interrupts = < 0 55 4 >;
> > > +               xlnx,datawidth = <0x40>;
> > > +       } ;
> > > +} ;
> > 
> > As in the other patch, the node name should be 'dma-controller@...' and the
> > inconsistend spacing could be fixed.
> 
> Ok will fix...
> 
> > 
> > Also, it seems this adds pretty much identical examples that just differ in the
> > compat string. Is that really needed?
> 
> Most of the properties are same across the three DMA's
> For AXI VDMA there are few required properties that are not required for AXI DMA/CDMA.
> That's why added example for the other IP's as well I mean for AXI DMA and CDMA.

It needs to be clear what properties are required/valid for each 
compatible string rather than relying on examples. I should be able to 
write or validate the examples based on the rest of the text.

Rob
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Appana Durga Kedareswara rao March 29, 2016, 5:48 a.m. UTC | #4
Hi Rob,

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, March 29, 2016 2:26 AM
> To: Appana Durga Kedareswara Rao
> Cc: Soren Brinkmann; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; galak@codeaurora.org; Michal Simek;
> vinod.koul@intel.com; dan.j.williams@intel.com; Anurag Kumar Vulisha;
> moritz.fischer@ettus.com; laurent.pinchart@ideasonboard.com;
> luis@debethencourt.com; Srikanth Vemula; Anirudha Sarangi;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; dmaengine@vger.kernel.org
> Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> AXI CDMA
> 
> On Mon, Mar 28, 2016 at 05:27:01AM +0000, Appana Durga Kedareswara Rao
> wrote:
> > Hi Soren,
> >
> > > -----Original Message-----
> > > From: Sören Brinkmann [mailto:soren.brinkmann@xilinx.com]
> > > Sent: Monday, March 28, 2016 12:58 AM
> > > To: Appana Durga Kedareswara Rao
> > > Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> > > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; Michal Simek;
> > > vinod.koul@intel.com; dan.j.williams@intel.com; Anurag Kumar
> > > Vulisha; Appana Durga Kedareswara Rao; moritz.fischer@ettus.com;
> > > laurent.pinchart@ideasonboard.com; luis@debethencourt.com; Srikanth
> > > Vemula; Anirudha Sarangi; devicetree@vger.kernel.org; linux-arm-
> > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > > dmaengine@vger.kernel.org
> > > Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding
> > > doc for AXI CDMA
> > >
> > > On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > > > This patch updates the device-tree binding doc for adding support
> > > > for AXI CDMA.
> > > >
> > > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> > > > ---
> > > > ---> Modified commit message as suggested by Vinod.
> > > > ---> Moved the patch to forward in the series as suggested by vinod.
> > > >
> > > >  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18
> > > +++++++++++++++++-
> > > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > index 5841421..2b0c12b 100644
> > > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > @@ -8,8 +8,12 @@ target devices. It can be configured to have one
> > > > channel
> > > or two channels.
> > > >  If configured as two channels, one is to transmit to the device
> > > > and another  is to receive from the device.
> > > >
> > > > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > > > +source address and a memory-mapped destination address.
> > > > +
> > > >  Required properties:
> > > > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > > > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> or
> > > > +	      "xlnx,axi-cdma-1.00.a""
> > > >  - #dma-cells: Should be <1>, see "dmas" property below
> > > >  - reg: Should contain VDMA registers location and length.
> > > >  - xlnx,num-fstores: Should be the number of framebuffers as
> > > > configured in
> > > h/w.
> > > > @@ -80,6 +84,18 @@ axi_dma_0: axidma@40400000 {
> > > >  	} ;
> > > >  } ;
> > > >
> > > > +axi_cdma_0: axicdma@7e200000 {
> > > > +       compatible = "xlnx,axi-cdma-1.00.a";
> > > > +       #dma-cells = <1>;
> > > > +       reg = < 0x7e200000 0x10000 >;
> > > > +       xlnx,addrwidth = <0x20>;
> > > > +       dma-channel@7e200000 {
> > > > +               compatible = "xlnx,axi-dma-mm2s-channel";
> > > > +               interrupts = < 0 55 4 >;
> > > > +               xlnx,datawidth = <0x40>;
> > > > +       } ;
> > > > +} ;
> > >
> > > As in the other patch, the node name should be 'dma-controller@...'
> > > and the inconsistend spacing could be fixed.
> >
> > Ok will fix...
> >
> > >
> > > Also, it seems this adds pretty much identical examples that just
> > > differ in the compat string. Is that really needed?
> >
> > Most of the properties are same across the three DMA's For AXI VDMA
> > there are few required properties that are not required for AXI DMA/CDMA.
> > That's why added example for the other IP's as well I mean for AXI DMA and
> CDMA.
> 
> It needs to be clear what properties are required/valid for each compatible
> string rather than relying on examples. I should be able to write or validate the
> examples based on the rest of the text.

Ok will fix it in the next version of the patch.

Regards,
Kedar.

> 
> Rob
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index 5841421..2b0c12b 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -8,8 +8,12 @@  target devices. It can be configured to have one channel or two channels.
 If configured as two channels, one is to transmit to the device and another
 is to receive from the device.
 
+Xilinx AXI CDMA engine, it does transfers between memory-mapped source
+address and a memory-mapped destination address.
+
 Required properties:
-- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
+- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
+	      "xlnx,axi-cdma-1.00.a""
 - #dma-cells: Should be <1>, see "dmas" property below
 - reg: Should contain VDMA registers location and length.
 - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
@@ -80,6 +84,18 @@  axi_dma_0: axidma@40400000 {
 	} ;
 } ;
 
+axi_cdma_0: axicdma@7e200000 {
+       compatible = "xlnx,axi-cdma-1.00.a";
+       #dma-cells = <1>;
+       reg = < 0x7e200000 0x10000 >;
+       xlnx,addrwidth = <0x20>;
+       dma-channel@7e200000 {
+               compatible = "xlnx,axi-dma-mm2s-channel";
+               interrupts = < 0 55 4 >;
+               xlnx,datawidth = <0x40>;
+       } ;
+} ;
+
 * DMA client
 
 Required properties: