| Message ID | 1457455195-1938-12-git-send-email-sre@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sebastian, Thank you for the patch. On Tuesday 08 Mar 2016 17:39:43 Sebastian Reichel wrote: > The FIFO thresholds must be configured by omapdrm for > manually updated DSI panels due to a hardware bug. I find the subject a bit misleading, it made me think that the patch added new methods, while it only declares them as part of the DSS public API. > Signed-off-By: Sebastian Reichel <sre@kernel.org> > --- > include/video/omapdss.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/video/omapdss.h b/include/video/omapdss.h > index 9bde65b79220..f6cdd809ae5c 100644 > --- a/include/video/omapdss.h > +++ b/include/video/omapdss.h > @@ -935,6 +935,12 @@ int dispc_ovl_setup(enum omap_plane plane, const struct > omap_overlay_info *oi, bool replication, const struct omap_video_timings > *mgr_timings, bool mem_to_mem); > > +void dispc_ovl_compute_fifo_thresholds(enum omap_plane plane, > + u32 *fifo_low, u32 *fifo_high, bool use_fifomerge, > + bool manual_update); > +void dispc_ovl_set_fifo_threshold(enum omap_plane plane, u32 low, u32 > high); Should you then remove the function declarations from drivers/gpu/drm/omapdrm/dss/dss.h ? > + > + One blank line is enough. > int omapdss_compat_init(void); > void omapdss_compat_uninit(void);
diff --git a/include/video/omapdss.h b/include/video/omapdss.h index 9bde65b79220..f6cdd809ae5c 100644 --- a/include/video/omapdss.h +++ b/include/video/omapdss.h @@ -935,6 +935,12 @@ int dispc_ovl_setup(enum omap_plane plane, const struct omap_overlay_info *oi, bool replication, const struct omap_video_timings *mgr_timings, bool mem_to_mem); +void dispc_ovl_compute_fifo_thresholds(enum omap_plane plane, + u32 *fifo_low, u32 *fifo_high, bool use_fifomerge, + bool manual_update); +void dispc_ovl_set_fifo_threshold(enum omap_plane plane, u32 low, u32 high); + + int omapdss_compat_init(void); void omapdss_compat_uninit(void);
The FIFO thresholds must be configured by omapdrm for manually updated DSI panels due to a hardware bug. Signed-off-By: Sebastian Reichel <sre@kernel.org> --- include/video/omapdss.h | 6 ++++++ 1 file changed, 6 insertions(+)