| Message ID | 1458770712-10880-10-git-send-email-mmcclint@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote: > Update the compatible string to add new device tree binding > > CC: linux-watchdog@vger.kernel.org > Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> > --- > Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > index 60bb2f98..45b37cf 100644 > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > @@ -6,6 +6,7 @@ Required properties : > > "qcom,kpss-timer" > "qcom,scss-timer" > + "qcom,kpss-standalone" What SoC(s) is this in. Use SoC specific compatible strings please. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote: > > On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote: >> Update the compatible string to add new device tree binding >> >> CC: linux-watchdog@vger.kernel.org >> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> >> --- >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >> index 60bb2f98..45b37cf 100644 >> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >> @@ -6,6 +6,7 @@ Required properties : >> >> "qcom,kpss-timer" >> "qcom,scss-timer" >> + "qcom,kpss-standalone" > > What SoC(s) is this in. Use SoC specific compatible strings please. So ipq4019 wins the race because we are the first to try to enable watchdog for this block? qcom,kpss-ipq4019 ? -M-- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 28, 2016 at 12:02 PM, Matthew McClintock <mmcclint@codeaurora.org> wrote: > On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote: >> >> On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote: >>> Update the compatible string to add new device tree binding >>> >>> CC: linux-watchdog@vger.kernel.org >>> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> >>> --- >>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >>> index 60bb2f98..45b37cf 100644 >>> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >>> @@ -6,6 +6,7 @@ Required properties : >>> >>> "qcom,kpss-timer" >>> "qcom,scss-timer" >>> + "qcom,kpss-standalone" >> >> What SoC(s) is this in. Use SoC specific compatible strings please. > > So ipq4019 wins the race because we are the first to try to enable watchdog for this block? Yep, that's how it is supposed to work. Newer chips claim compatibility with older ones. > qcom,kpss-ipq4019 ? Yes, but generally <vendor>,<soc>-<block> is preferred order. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 28, 2016 at 12:02:47PM -0500, Matthew McClintock wrote: > On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote: > > > > On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote: > >> Update the compatible string to add new device tree binding > >> > >> CC: linux-watchdog@vger.kernel.org > >> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> > >> --- > >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> index 60bb2f98..45b37cf 100644 > >> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > >> @@ -6,6 +6,7 @@ Required properties : > >> > >> "qcom,kpss-timer" > >> "qcom,scss-timer" > >> + "qcom,kpss-standalone" > > > > What SoC(s) is this in. Use SoC specific compatible strings please. > > So ipq4019 wins the race because we are the first to try to enable watchdog for this block? > > qcom,kpss-ipq4019 ? > It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not refer to a specific block. Devicetree maintainers may have a better idea, but it seems to me that there should be 'wdt' or 'watchdog' in the property name. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mar 28, 2016, at 1:15 PM, Guenter Roeck <linux@roeck-us.net> wrote: > >>> What SoC(s) is this in. Use SoC specific compatible strings please. >> >> So ipq4019 wins the race because we are the first to try to enable watchdog for this block? >> >> qcom,kpss-ipq4019 ? >> > It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not > refer to a specific block. Devicetree maintainers may have a better idea, > but it seems to me that there should be 'wdt' or 'watchdog' in the property > name. Sounds fine to me, if no one has any other comments I’ll use this one in the next spin of the patch. -M-- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt index 60bb2f98..45b37cf 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt @@ -6,6 +6,7 @@ Required properties : "qcom,kpss-timer" "qcom,scss-timer" + "qcom,kpss-standalone" - reg : shall contain base register location and length - clocks : shall contain the input clock
Update the compatible string to add new device tree binding CC: linux-watchdog@vger.kernel.org Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org> --- Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 + 1 file changed, 1 insertion(+)