diff mbox

ASoC: intel: make Kconfig selects depend on ACPI

Message ID 56FAB111.2070503@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap March 29, 2016, 4:45 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is
not enabled.  This fixes the kconfig warning:

warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_BYTCR_RT5651_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH && SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH) selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && ACPI)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Jie Yang <yang.jie@linux.intel.com>
Cc:	alsa-devel@alsa-project.org
---
 sound/soc/intel/Kconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Mark Brown March 29, 2016, 4:51 p.m. UTC | #1 
On Tue, Mar 29, 2016 at 09:45:05AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is
> not enabled.  This fixes the kconfig warning:

These are drivers which can't be instantiated without ACPI...
Randy Dunlap March 29, 2016, 7:01 p.m. UTC | #2 
On 03/29/16 09:51, Mark Brown wrote:
> On Tue, Mar 29, 2016 at 09:45:05AM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is
>> not enabled.  This fixes the kconfig warning:
> 
> These are drivers which can't be instantiated without ACPI...
> 

so it sounds like they should depend on ACPI...?
diff mbox

Patch

--- linux-next-20160308.orig/sound/soc/intel/Kconfig
+++ linux-next-20160308/sound/soc/intel/Kconfig
@@ -100,7 +100,7 @@  config SND_SOC_INTEL_BYTCR_RT5640_MACH
 	depends on X86 && I2C
 	select SND_SOC_RT5640
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
           This adds support for ASoC machine driver for Intel(R) Baytrail and Baytrail-CR
@@ -113,7 +113,7 @@  config SND_SOC_INTEL_BYTCR_RT5651_MACH
 	depends on X86 && I2C
 	select SND_SOC_RT5651
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
           This adds support for ASoC machine driver for Intel(R) Baytrail and Baytrail-CR
@@ -126,7 +126,7 @@  config SND_SOC_INTEL_CHT_BSW_RT5672_MACH
         depends on X86_INTEL_LPSS && I2C
         select SND_SOC_RT5670
         select SND_SST_MFLD_PLATFORM
-        select SND_SST_IPC_ACPI
+        select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
         help
           This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell
@@ -139,7 +139,7 @@  config SND_SOC_INTEL_CHT_BSW_RT5645_MACH
 	depends on X86_INTEL_LPSS && I2C
 	select SND_SOC_RT5645
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
 	  This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell
@@ -152,7 +152,7 @@  config SND_SOC_INTEL_CHT_BSW_MAX98090_TI
 	select SND_SOC_MAX98090
 	select SND_SOC_TS3A227E
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
       This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell