| Message ID | 1457946110-4612-1-git-send-email-t-kristo@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 14 March 2016 02:31 PM, Tero Kristo wrote: > EDMA was allocating DMA channels 32 and 33 for memcpy usage, out of which > channel 33 is actually used by DES crypto engine. This bad allocation of > the channel causes a crash in the DES crypto engine, as the channel > gets configured for memcpy usage instead of hardware <-> memory DMA. > > Fixed by allocating DMA channels 58 and 59 for memcpy usage (I2C0 RX/TX), > which are not used by anybody. Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > arch/arm/boot/dts/am4372.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 92068fb..cdd3d78 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -207,7 +207,7 @@ > ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>, > <&edma_tptc2 0>; > > - ti,edma-memcpy-channels = <32 33>; > + ti,edma-memcpy-channels = <58 59>; > }; > > edma_tptc0: tptc@49800000 { >
* Tero Kristo <t-kristo@ti.com> [160314 02:02]: > EDMA was allocating DMA channels 32 and 33 for memcpy usage, out of which > channel 33 is actually used by DES crypto engine. This bad allocation of > the channel causes a crash in the DES crypto engine, as the channel > gets configured for memcpy usage instead of hardware <-> memory DMA. > > Fixed by allocating DMA channels 58 and 59 for memcpy usage (I2C0 RX/TX), > which are not used by anybody. Thanks applying into omap-for-v4.6/fixes with Cc stable v4.4+. Tony
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 92068fb..cdd3d78 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -207,7 +207,7 @@ ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>, <&edma_tptc2 0>; - ti,edma-memcpy-channels = <32 33>; + ti,edma-memcpy-channels = <58 59>; }; edma_tptc0: tptc@49800000 {
EDMA was allocating DMA channels 32 and 33 for memcpy usage, out of which channel 33 is actually used by DES crypto engine. This bad allocation of the channel causes a crash in the DES crypto engine, as the channel gets configured for memcpy usage instead of hardware <-> memory DMA. Fixed by allocating DMA channels 58 and 59 for memcpy usage (I2C0 RX/TX), which are not used by anybody. Signed-off-by: Tero Kristo <t-kristo@ti.com> Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- arch/arm/boot/dts/am4372.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)