| Message ID | 20160312113357.14480.40374.stgit@Solace.station (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Typo in email title "operaions". Wei.
On Sat, Mar 12, 2016 at 12:33:57PM +0100, Dario Faggioli wrote: > (i.e., domain creation and destruction) so the > trace will show properly decoded info, rather > than just a bunch of hex codes. Weirdly you also lost your SoB. > --- > Cc: George Dunlap <george.dunlap@eu.citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > Changes from v1: > * new patch in the series. > --- > tools/xentrace/xenalyze.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index d4a5b0c..353bed7 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -8388,6 +8388,30 @@ void hw_process(struct pcpu_info *p) > } > > } > + > +#define TRC_DOM0_SUB_DOMOPS 1 > +void dom0_process(struct pcpu_info *p) > +{ > + struct record_info *ri = &p->ri; > + > + switch(ri->evt.sub) > + { > + case TRC_DOM0_SUB_DOMOPS: > + if(opt.dump_all) { > + struct { > + unsigned int domid; > + } *r = (typeof(r))ri->d; > + > + printf(" %s %s domain d%u\n", ri->dump_header, > + ri->event == TRC_DOM0_DOM_ADD ? "creating" : "destroying", > + r->domid); > + } > + break; > + default: > + process_generic(&p->ri); > + } > +} > + > /* ---- Base ----- */ > void dump_generic(FILE * f, struct record_info *ri) > { > @@ -9224,6 +9248,8 @@ void process_record(struct pcpu_info *p) { > hw_process(p); > break; > case TRC_DOM0OP_MAIN: > + dom0_process(p); > + break; > default: > process_generic(ri); > } >
On Mon, 2016-03-14 at 10:06 -0400, Konrad Rzeszutek Wilk wrote: > On Sat, Mar 12, 2016 at 12:33:57PM +0100, Dario Faggioli wrote: > > > > (i.e., domain creation and destruction) so the > > trace will show properly decoded info, rather > > than just a bunch of hex codes. > Weirdly you also lost your SoB. > So, typo in subject and no SoB... What a great patch I sent!! :-O I guess I'll resend. :-) Sorry and Regards, Dario
On 12/03/16 11:33, Dario Faggioli wrote: > (i.e., domain creation and destruction) so the > trace will show properly decoded info, rather > than just a bunch of hex codes. > --- For some reason git won't apply your 'v2', complaining: 'corrupt patch at line 14'. But re the content (i.e., this patch with the SoB and the title fixed) Acked-by: George Dunlap <george.dunlap@citrix.com> Sorry it took so long to get to this. > Cc: George Dunlap <george.dunlap@eu.citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > Changes from v1: > * new patch in the series. > --- > tools/xentrace/xenalyze.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index d4a5b0c..353bed7 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -8388,6 +8388,30 @@ void hw_process(struct pcpu_info *p) > } > > } > + > +#define TRC_DOM0_SUB_DOMOPS 1 > +void dom0_process(struct pcpu_info *p) > +{ > + struct record_info *ri = &p->ri; > + > + switch(ri->evt.sub) > + { > + case TRC_DOM0_SUB_DOMOPS: > + if(opt.dump_all) { > + struct { > + unsigned int domid; > + } *r = (typeof(r))ri->d; > + > + printf(" %s %s domain d%u\n", ri->dump_header, > + ri->event == TRC_DOM0_DOM_ADD ? "creating" : "destroying", > + r->domid); > + } > + break; > + default: > + process_generic(&p->ri); > + } > +} > + > /* ---- Base ----- */ > void dump_generic(FILE * f, struct record_info *ri) > { > @@ -9224,6 +9248,8 @@ void process_record(struct pcpu_info *p) { > hw_process(p); > break; > case TRC_DOM0OP_MAIN: > + dom0_process(p); > + break; > default: > process_generic(ri); > } >
On Wed, Mar 23, 2016 at 12:35:36PM +0000, George Dunlap wrote: > On 12/03/16 11:33, Dario Faggioli wrote: > > (i.e., domain creation and destruction) so the > > trace will show properly decoded info, rather > > than just a bunch of hex codes. > > --- > > For some reason git won't apply your 'v2', complaining: 'corrupt patch > at line 14'. /me nods. Same here. I tried to check it in but couldn't. Dariof could you make a git branch to pull in the Acked patches please? > > But re the content (i.e., this patch with the SoB and the title fixed) > > Acked-by: George Dunlap <george.dunlap@citrix.com> > > Sorry it took so long to get to this. > > > > Cc: George Dunlap <george.dunlap@eu.citrix.com> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > Cc: Wei Liu <wei.liu2@citrix.com> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- > > Changes from v1: > > * new patch in the series. > > --- > > tools/xentrace/xenalyze.c | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > > index d4a5b0c..353bed7 100644 > > --- a/tools/xentrace/xenalyze.c > > +++ b/tools/xentrace/xenalyze.c > > @@ -8388,6 +8388,30 @@ void hw_process(struct pcpu_info *p) > > } > > > > } > > + > > +#define TRC_DOM0_SUB_DOMOPS 1 > > +void dom0_process(struct pcpu_info *p) > > +{ > > + struct record_info *ri = &p->ri; > > + > > + switch(ri->evt.sub) > > + { > > + case TRC_DOM0_SUB_DOMOPS: > > + if(opt.dump_all) { > > + struct { > > + unsigned int domid; > > + } *r = (typeof(r))ri->d; > > + > > + printf(" %s %s domain d%u\n", ri->dump_header, > > + ri->event == TRC_DOM0_DOM_ADD ? "creating" : "destroying", > > + r->domid); > > + } > > + break; > > + default: > > + process_generic(&p->ri); > > + } > > +} > > + > > /* ---- Base ----- */ > > void dump_generic(FILE * f, struct record_info *ri) > > { > > @@ -9224,6 +9248,8 @@ void process_record(struct pcpu_info *p) { > > hw_process(p); > > break; > > case TRC_DOM0OP_MAIN: > > + dom0_process(p); > > + break; > > default: > > process_generic(ri); > > } > > >
On Fri, 2016-03-25 at 09:29 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 23, 2016 at 12:35:36PM +0000, George Dunlap wrote: > > > > On 12/03/16 11:33, Dario Faggioli wrote: > > > > > > (i.e., domain creation and destruction) so the > > > trace will show properly decoded info, rather > > > than just a bunch of hex codes. > > > --- > > For some reason git won't apply your 'v2', complaining: 'corrupt > > patch > > at line 14'. > /me nods. Same here. I tried to check it in but couldn't. > > Dariof could you make a git branch to pull in the Acked patches > please? > Here it comes: git://xenbits.xen.org/people/dariof/xen.git tracing/sched-events-improvements-leftover http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/tracing/sched-events-improvements-leftover As far as I can tell, it is these two patches that are still unapplied, and can go in: xenalyze: handle RTDS scheduler events xenalyze: handle DOM0 operations events (the first two commits of the branch, of course.) Sorry it took a bit, but I lost track of what actually went in and what didn't for this series... :-/ Thanks and Regards, Dario
Dario Faggioli writes ("git branch for checking-in leftover patches [was: Re: [Xen-devel] [PATCH 1/3] xenalyze: handle DOM0 operaions events]"):
> git://xenbits.xen.org/people/dariof/xen.git tracing/sched-events-improvements-leftover
> http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/tracing/sched-events-improvements-leftover
>
> As far as I can tell, it is these two patches that are still unapplied,
> and can go in:
>
> xenalyze: handle RTDS scheduler events
> xenalyze: handle DOM0 operations events
Thanks. I have rebased those onto staging and applied them.
Ian.
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index d4a5b0c..353bed7 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -8388,6 +8388,30 @@ void hw_process(struct pcpu_info *p) } } + +#define TRC_DOM0_SUB_DOMOPS 1 +void dom0_process(struct pcpu_info *p) +{ + struct record_info *ri = &p->ri; + + switch(ri->evt.sub) + { + case TRC_DOM0_SUB_DOMOPS: + if(opt.dump_all) { + struct { + unsigned int domid; + } *r = (typeof(r))ri->d; + + printf(" %s %s domain d%u\n", ri->dump_header, + ri->event == TRC_DOM0_DOM_ADD ? "creating" : "destroying", + r->domid); + } + break; + default: + process_generic(&p->ri); + } +} + /* ---- Base ----- */ void dump_generic(FILE * f, struct record_info *ri) { @@ -9224,6 +9248,8 @@ void process_record(struct pcpu_info *p) { hw_process(p); break; case TRC_DOM0OP_MAIN: + dom0_process(p); + break; default: process_generic(ri); }