| Message ID | 56FE7AC4.4090508@fivetechno.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 01.04.2016 22:42, Markus Reichl wrote: > Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on > odroid XU3 and XU4 to avoid warnings in dmesg output. What warnings? > > Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1bd507b..eec425a 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -121,7 +121,7 @@ > }; > > ldo3_reg: LDO3 { > - regulator-name = "vdd_ldo3"; > + regulator-name = "vddq_mmc0"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-always-on; > @@ -184,7 +184,7 @@ > }; > > ldo13_reg: LDO13 { > - regulator-name = "vdd_ldo13"; > + regulator-name = "vddq_mmc2"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > regulator-always-on; > @@ -211,6 +211,13 @@ > regulator-always-on; > }; > > + ldo18_reg: LDO18 { > + regulator-name = "vdd_emmc_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; In the same patchset you add always-on and remove. What is the point of this juggle? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, Am 04.04.2016 um 02:28 schrieb Krzysztof Kozlowski: > On 01.04.2016 22:42, Markus Reichl wrote: >> Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on >> odroid XU3 and XU4 to avoid warnings in dmesg output. > > What warnings? [ 1.843689] dwmmc_exynos 12200000.mmc: Looking up vmmc-supply property in node /mmc@12200000 failed [ 1.843773] dwmmc_exynos 12200000.mmc: Looking up vqmmc-supply property in node /mmc@12200000 failed [ 1.912340] dwmmc_exynos 12220000.mmc: Looking up vmmc-supply property in node /mmc@12220000 failed [ 1.912410] dwmmc_exynos 12220000.mmc: Looking up vqmmc-supply property in node /mmc@12220000 failed > >> >> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> index 1bd507b..eec425a 100644 >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> @@ -121,7 +121,7 @@ >> }; >> >> ldo3_reg: LDO3 { >> - regulator-name = "vdd_ldo3"; >> + regulator-name = "vddq_mmc0"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <1800000>; >> regulator-always-on; >> @@ -184,7 +184,7 @@ >> }; >> >> ldo13_reg: LDO13 { >> - regulator-name = "vdd_ldo13"; >> + regulator-name = "vddq_mmc2"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <2800000>; >> regulator-always-on; >> @@ -211,6 +211,13 @@ >> regulator-always-on; >> }; >> >> + ldo18_reg: LDO18 { >> + regulator-name = "vdd_emmc_1V8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; > > In the same patchset you add always-on and remove. What is the point of > this juggle? I will squash the two patches together in one. > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Servus, -- Markus Reichl -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index 1bd507b..eec425a 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -121,7 +121,7 @@ }; ldo3_reg: LDO3 { - regulator-name = "vdd_ldo3"; + regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; @@ -184,7 +184,7 @@ }; ldo13_reg: LDO13 { - regulator-name = "vdd_ldo13"; + regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-always-on; @@ -211,6 +211,13 @@ regulator-always-on; }; + ldo18_reg: LDO18 { + regulator-name = "vdd_emmc_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + ldo19_reg: LDO19 { regulator-name = "vdd_sd"; regulator-min-microvolt = <2800000>; @@ -347,6 +354,8 @@ cap-mmc-highspeed; mmc-hs200-1_8v; mmc-hs400-1_8v; + vmmc-supply = <&ldo18_reg>; + vqmmc-supply = <&ldo3_reg>; }; &mmc_2 { @@ -359,6 +368,8 @@ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; bus-width = <4>; cap-sd-highspeed; + vmmc-supply = <&ldo19_reg>; + vqmmc-supply = <&ldo13_reg>; }; &pinctrl_0 {
Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output. Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)