| Message ID | 1459113058-14340-3-git-send-email-paul.gortmaker@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Mar 27, 2016 at 05:10:56PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/bus/Kconfig:config IMX_WEIM > drivers/bus/Kconfig: bool "Freescale EIM DRIVER > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Shawn Guo <shawn.guo@linaro.org> Acked-by: Shawn Guo <shawn.guo@linaro.org> > Cc: Alison Chaiken <alison_chaiken@mentor.com> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 1827fc4d15c1..d8592d9d2bc3 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -7,7 +7,7 @@ * License version 2. This program is licensed "as is" without any * warranty of any kind, whether express or implied. */ -#include <linux/module.h> +#include <linux/init.h> #include <linux/clk.h> #include <linux/io.h> #include <linux/of_device.h> @@ -57,7 +57,6 @@ static const struct of_device_id weim_id_table[] = { { .compatible = "fsl,imx51-weim", .data = &imx51_weim_devtype, }, { } }; -MODULE_DEVICE_TABLE(of, weim_id_table); static int __init imx_weim_gpr_setup(struct platform_device *pdev) { @@ -210,8 +209,4 @@ static struct platform_driver weim_driver = { .of_match_table = weim_id_table, }, }; -module_platform_driver_probe(weim_driver, weim_probe); - -MODULE_AUTHOR("Freescale Semiconductor Inc."); -MODULE_DESCRIPTION("i.MX EIM Controller Driver"); -MODULE_LICENSE("GPL"); +builtin_platform_driver_probe(weim_driver, weim_probe);
The Kconfig currently controlling compilation of this code is: drivers/bus/Kconfig:config IMX_WEIM drivers/bus/Kconfig: bool "Freescale EIM DRIVER ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Alison Chaiken <alison_chaiken@mentor.com> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/bus/imx-weim.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)