| Message ID | 1460027764-27428-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 04/07/2016 01:16 PM, Sudip Mukherjee wrote: > If the firmware upload or the firmware verification fails then we > printed the error message and exited but we missed releasing the > firmware. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > --- > drivers/net/ieee802154/adf7242.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index 89154c0..91d4531 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1030,6 +1030,7 @@ static int adf7242_hw_init(struct adf7242_local *lp) > if (ret) { > dev_err(&lp->spi->dev, > "upload firmware failed with %d\n", ret); > + release_firmware(fw); > return ret; > } > > @@ -1037,6 +1038,7 @@ static int adf7242_hw_init(struct adf7242_local *lp) > if (ret) { > dev_err(&lp->spi->dev, > "verify firmware failed with %d\n", ret); > + release_firmware(fw); > return ret; > } > >
Hi Sudip, > If the firmware upload or the firmware verification fails then we > printed the error message and exited but we missed releasing the > firmware. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > --- > drivers/net/ieee802154/adf7242.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index 89154c0..91d4531 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -1030,6 +1030,7 @@ static int adf7242_hw_init(struct adf7242_local *lp) if (ret) { dev_err(&lp->spi->dev, "upload firmware failed with %d\n", ret); + release_firmware(fw); return ret; } @@ -1037,6 +1038,7 @@ static int adf7242_hw_init(struct adf7242_local *lp) if (ret) { dev_err(&lp->spi->dev, "verify firmware failed with %d\n", ret); + release_firmware(fw); return ret; }
If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- drivers/net/ieee802154/adf7242.c | 2 ++ 1 file changed, 2 insertions(+)