diff mbox

[1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

Message ID 1459782600-16073-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson April 4, 2016, 3:09 p.m. UTC 
We must set rc before using `goto out'.

Bug introduced in bf7628f0 "libxl: add pvusb API".

CID: 1358113
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: coverity@xenproject.org
CC: Simon Cao <caobosimon@gmail.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Chunyan Liu <cyliu@suse.com>
---
 tools/libxl/libxl_pvusb.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Chunyan Liu April 7, 2016, 8:17 a.m. UTC | #1 
Thanks, Ian!

>>> On 4/4/2016 at 11:09 PM, in message
<1459782600-16073-1-git-send-email-ian.jackson@eu.citrix.com>, Ian Jackson
<ian.jackson@eu.citrix.com> wrote: 
> We must set rc before using `goto out'. 
>  
> Bug introduced in bf7628f0 "libxl: add pvusb API". 
>  
> CID: 1358113 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> 
> CC: coverity@xenproject.org 
> CC: Simon Cao <caobosimon@gmail.com> 
> CC: George Dunlap <george.dunlap@citrix.com> 
> CC: Chunyan Liu <cyliu@suse.com> 
> --- 
>  tools/libxl/libxl_pvusb.c |    1 + 
>  1 file changed, 1 insertion(+) 
>  
> diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c 
> index 5f92628..6f53317 100644 
> --- a/tools/libxl/libxl_pvusb.c 
> +++ b/tools/libxl/libxl_pvusb.c 
> @@ -905,6 +905,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc  
> *gc, uint32_t domid, 
>                                      usbdev->u.hostdev.hostaddr); 
>      if (!busid) { 
>          LOG(DEBUG, "Fail to get busid of usb device"); 
> +        rc = ERROR_FAIL; 
>          goto out; 
>      } 
>
Ian Jackson April 7, 2016, 5:04 p.m. UTC | #2 
Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid"):
> Thanks, Ian!

Should I take that as a Reviewed-by ?

Thanks,
Ian.
Chunyan Liu April 8, 2016, 3:48 a.m. UTC | #3 
>>> On 4/8/2016 at 01:04 AM, in message
<22278.37677.975595.101165@mariner.uk.xensource.com>, Ian Jackson
<Ian.Jackson@eu.citrix.com> wrote: 
> Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of  
> usbdev_busaddr_to_busid"): 
> > Thanks, Ian! 
>  
> Should I take that as a Reviewed-by ? 

Ah, yes. Acked. :-)

Chunyan

>  
> Thanks, 
> Ian. 
>  
>
Ian Jackson April 8, 2016, 1:34 p.m. UTC | #4 
Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid"):
> On 4/8/2016 at 01:04 AM, in message
> <22278.37677.975595.101165@mariner.uk.xensource.com>, Ian Jackson
> <Ian.Jackson@eu.citrix.com> wrote: 
> > Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of  
> > usbdev_busaddr_to_busid"): 
> > > Thanks, Ian! 
> >  
> > Should I take that as a Reviewed-by ? 
> 
> Ah, yes. Acked. :-)

Thanks, queued.

Ian.
diff mbox

Patch

diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
index 5f92628..6f53317 100644
--- a/tools/libxl/libxl_pvusb.c
+++ b/tools/libxl/libxl_pvusb.c
@@ -905,6 +905,7 @@  static int libxl__device_usbdev_add_xenstore(libxl__gc *gc, uint32_t domid,
                                     usbdev->u.hostdev.hostaddr);
     if (!busid) {
         LOG(DEBUG, "Fail to get busid of usb device");
+        rc = ERROR_FAIL;
         goto out;
     }