| Message ID | 20110530124826.74d83b35@absol.kitzblitz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 30 May 2011 12:48:26 +0200, Nicolas Kaiser <nikai@nikai.net> wrote: > if (mode->clock < 20000) > - return MODE_CLOCK_HIGH; > + return MODE_CLOCK_LOW; Seems obvious to me. Reviewed-by: Keith Packard <keithp@keithp.com>
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index f289b86..655bbd9 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -194,7 +194,7 @@ static int intel_hdmi_mode_valid(struct drm_connector *connector, if (mode->clock > 165000) return MODE_CLOCK_HIGH; if (mode->clock < 20000) - return MODE_CLOCK_HIGH; + return MODE_CLOCK_LOW; if (mode->flags & DRM_MODE_FLAG_DBLSCAN) return MODE_NO_DBLESCAN;
Forwarding to Keith Packard. Sorry, initially sent to the previous maintainer instead. Start weitergeleitete Nachricht: Datum: Fri, 20 May 2011 18:58:53 +0200 Von: Nicolas Kaiser <nikai@nikai.net> An: Chris Wilson <chris@chris-wilson.co.uk> Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Betreff: [PATCH] drm: i915: correct return status in intel_hdmi_mode_valid() Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- Untested: just looks to me like the intention might be to return MODE_CLOCK_LOW here, is that correct? drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)