| Message ID | 903e7f51989907f3de2159efb99bd65bf3dc30f7.1460379702.git.vilhelm.gray@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 11 Apr 2016 15:25:52 +0200, William Breathitt Gray wrote: > > The 'size' member of a struct firmware is passed to snd_printk with a > respective format string using the %d identifier. The 'size' member is > of type size_t, but format identifier %d indicates a signed int data > type. This patch replaces the %d format identifier with the correct %zu > format identifier for size_t data types. > > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> This is basically irrelevant from ISA issue you're trying to solve, so I'm going to apply this one individually to my tree. thanks, Takashi > --- > sound/isa/sscape.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c > index 7b248cd..fdcfa29 100644 > --- a/sound/isa/sscape.c > +++ b/sound/isa/sscape.c > @@ -591,7 +591,7 @@ static int sscape_upload_microcode(struct snd_card *card, int version) > } > err = upload_dma_data(sscape, init_fw->data, init_fw->size); > if (err == 0) > - snd_printk(KERN_INFO "sscape: MIDI firmware loaded %d KBs\n", > + snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n", > init_fw->size >> 10); > > release_firmware(init_fw); > -- > 2.7.3 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c index 7b248cd..fdcfa29 100644 --- a/sound/isa/sscape.c +++ b/sound/isa/sscape.c @@ -591,7 +591,7 @@ static int sscape_upload_microcode(struct snd_card *card, int version) } err = upload_dma_data(sscape, init_fw->data, init_fw->size); if (err == 0) - snd_printk(KERN_INFO "sscape: MIDI firmware loaded %d KBs\n", + snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n", init_fw->size >> 10); release_firmware(init_fw);
The 'size' member of a struct firmware is passed to snd_printk with a respective format string using the %d identifier. The 'size' member is of type size_t, but format identifier %d indicates a signed int data type. This patch replaces the %d format identifier with the correct %zu format identifier for size_t data types. Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- sound/isa/sscape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)