| Message ID | 20110605130207.GE11521@ZenIV.linux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> writes: > diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c > index 9a80a92..5efaf5f 100644 > --- a/net/sunrpc/rpcb_clnt.c > +++ b/net/sunrpc/rpcb_clnt.c > @@ -193,7 +193,7 @@ static int rpcb_create_local_unix(void) > if (IS_ERR(clnt)) { > dprintk("RPC: failed to create AF_LOCAL rpcbind " > "client (errno %ld).\n", PTR_ERR(clnt)); > - result = -PTR_ERR(clnt); > + result = PTR_ERR(clnt); > goto out; > } > > @@ -242,7 +242,7 @@ static int rpcb_create_local_net(void) > if (IS_ERR(clnt)) { > dprintk("RPC: failed to create local rpcbind " > "client (errno %ld).\n", PTR_ERR(clnt)); > - result = -PTR_ERR(clnt); > + result = PTR_ERR(clnt); Proabably the dprintk argument should be negated as well. Andreas.
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index 9a80a92..5efaf5f 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -193,7 +193,7 @@ static int rpcb_create_local_unix(void) if (IS_ERR(clnt)) { dprintk("RPC: failed to create AF_LOCAL rpcbind " "client (errno %ld).\n", PTR_ERR(clnt)); - result = -PTR_ERR(clnt); + result = PTR_ERR(clnt); goto out; } @@ -242,7 +242,7 @@ static int rpcb_create_local_net(void) if (IS_ERR(clnt)) { dprintk("RPC: failed to create local rpcbind " "client (errno %ld).\n", PTR_ERR(clnt)); - result = -PTR_ERR(clnt); + result = PTR_ERR(clnt); goto out; }
commit 7402ab19cdd5943c7dd4f3399afe3abda8077ef5 (SUNRPC: Use AF_LOCAL for rpcbind upcalls) broke rpcb_create_local() error reporting in several cases. Callers expect negative return value on error and until that commit they used to get it in all failure exits. Now if rpc_create() fails we get -PTR_ERR(clnt), i.e. *positive* value. Restore original behaviour... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html