diff mbox

[1/4] ASoC: Export snd_soc_find_dai()

Message ID 5e7147f76b2c54d2d23eb1f6a1146a3716bd5172.1461042239.git.mengdong.lin@linux.intel.com (mailing list archive)
State Accepted
Commit 305e9020f09d28560373c0112682e6fd11e909f6
Headers show

Commit Message

mengdong.lin@linux.intel.com April 19, 2016, 5:12 a.m. UTC 
From: Mengdong Lin <mengdong.lin@linux.intel.com>

This API can be used by topology to find an existing BE dai by name
and further configure it.

Topology will also check DAI ID to avoid wrong match.

Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>

Comments

Mark Brown April 20, 2016, 4:12 p.m. UTC | #1 
On Tue, Apr 19, 2016 at 01:12:25PM +0800, mengdong.lin@linux.intel.com wrote:

>  }
>  
> -static struct snd_soc_dai *snd_soc_find_dai(
> +struct snd_soc_dai *snd_soc_find_dai(
>  	const struct snd_soc_dai_link_component *dlc)
>  {
>  	struct snd_soc_component *component;
> @@ -959,6 +959,7 @@ static struct snd_soc_dai *snd_soc_find_dai(
>  
>  	return NULL;
>  }
> +EXPORT_SYMBOL_GPL(snd_soc_find_dai);

Can you please add a kerneldoc comment as well since this is getting
exported?
mengdong.lin@linux.intel.com April 21, 2016, 6:55 a.m. UTC | #2 
On 04/21/2016 12:12 AM, Mark Brown wrote:
> On Tue, Apr 19, 2016 at 01:12:25PM +0800, mengdong.lin@linux.intel.com wrote:
>
>>   }
>>
>> -static struct snd_soc_dai *snd_soc_find_dai(
>> +struct snd_soc_dai *snd_soc_find_dai(
>>   	const struct snd_soc_dai_link_component *dlc)
>>   {
>>   	struct snd_soc_component *component;
>> @@ -959,6 +959,7 @@ static struct snd_soc_dai *snd_soc_find_dai(
>>
>>   	return NULL;
>>   }
>> +EXPORT_SYMBOL_GPL(snd_soc_find_dai);
>
> Can you please add a kerneldoc comment as well since this is getting
> exported?
>

Okay, I'll do this. Thanks for your reminding.

Regards
Mengdong
diff mbox

Patch

diff --git a/include/sound/soc.h b/include/sound/soc.h
index 02b4a21..7687e2d 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1683,6 +1683,9 @@  void snd_soc_remove_dai_link(struct snd_soc_card *card,
 int snd_soc_register_dai(struct snd_soc_component *component,
 	struct snd_soc_dai_driver *dai_drv);
 
+struct snd_soc_dai *snd_soc_find_dai(
+	const struct snd_soc_dai_link_component *dlc);
+
 #include <sound/soc-dai.h>
 
 #ifdef CONFIG_DEBUG_FS
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index d2e62b15..07663de 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -930,7 +930,7 @@  static struct snd_soc_component *soc_find_component(
 	return NULL;
 }
 
-static struct snd_soc_dai *snd_soc_find_dai(
+struct snd_soc_dai *snd_soc_find_dai(
 	const struct snd_soc_dai_link_component *dlc)
 {
 	struct snd_soc_component *component;
@@ -959,6 +959,7 @@  static struct snd_soc_dai *snd_soc_find_dai(
 
 	return NULL;
 }
+EXPORT_SYMBOL_GPL(snd_soc_find_dai);
 
 static bool soc_is_dai_link_bound(struct snd_soc_card *card,
 		struct snd_soc_dai_link *dai_link)