| Message ID | bbb2f28f39cbda8923eedca61bb5d9c55520f674.1460379702.git.vilhelm.gray@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 4/11/2016 3:25 PM, William Breathitt Gray wrote: > The PNPBIOS driver requires preprocessor defines (located in > include/asm/segment.h) only declared if the architecture is set to > X86_32. If the architecture is set to X86_64, the PNPBIOS driver will > not build properly. The X86 dependecy for the PNPBIOS configuration > option is changed to an explicit X86_32 dependency in order to prevent > an attempt to build for an unsupported architecture. > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Has anyone taken care of this already? If not, can you possibly resend this patch with a CC to linux-acpi@vger.kernel.org so I can pick it up via Patchwork more easily? > --- > drivers/pnp/pnpbios/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pnp/pnpbios/Kconfig b/drivers/pnp/pnpbios/Kconfig > index 50c3dd0..a786086 100644 > --- a/drivers/pnp/pnpbios/Kconfig > +++ b/drivers/pnp/pnpbios/Kconfig > @@ -3,7 +3,7 @@ > # > config PNPBIOS > bool "Plug and Play BIOS support" > - depends on ISA && X86 > + depends on ISA && X86_32 > default n > ---help--- > Linux uses the PNPBIOS as defined in "Plug and Play BIOS
On Sat, Apr 23, 2016 at 01:51:19AM +0200, Rafael J. Wysocki wrote: >On 4/11/2016 3:25 PM, William Breathitt Gray wrote: >> The PNPBIOS driver requires preprocessor defines (located in >> include/asm/segment.h) only declared if the architecture is set to >> X86_32. If the architecture is set to X86_64, the PNPBIOS driver will >> not build properly. The X86 dependecy for the PNPBIOS configuration >> option is changed to an explicit X86_32 dependency in order to prevent >> an attempt to build for an unsupported architecture. >> >> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >Has anyone taken care of this already? > >If not, can you possibly resend this patch with a CC to >linux-acpi@vger.kernel.org so I can pick it up via Patchwork more easily? Greg K-H, Will this patch appear in the driver-core repository along with the other patches in this set? Thanks, William Breathitt Gray
On Sat, Apr 23, 2016 at 01:51:19AM +0200, Rafael J. Wysocki wrote: >On 4/11/2016 3:25 PM, William Breathitt Gray wrote: >> The PNPBIOS driver requires preprocessor defines (located in >> include/asm/segment.h) only declared if the architecture is set to >> X86_32. If the architecture is set to X86_64, the PNPBIOS driver will >> not build properly. The X86 dependecy for the PNPBIOS configuration >> option is changed to an explicit X86_32 dependency in order to prevent >> an attempt to build for an unsupported architecture. >> >> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >Has anyone taken care of this already? > >If not, can you possibly resend this patch with a CC to >linux-acpi@vger.kernel.org so I can pick it up via Patchwork more easily? I'm not sure when this patchset will appear in driver-core, so I have resent this particular patch with a CC to linux-acpi@vger.kernel.org so that Rafael J. Wysocki can pick it up more easily. William Breathitt Gray
diff --git a/drivers/pnp/pnpbios/Kconfig b/drivers/pnp/pnpbios/Kconfig index 50c3dd0..a786086 100644 --- a/drivers/pnp/pnpbios/Kconfig +++ b/drivers/pnp/pnpbios/Kconfig @@ -3,7 +3,7 @@ # config PNPBIOS bool "Plug and Play BIOS support" - depends on ISA && X86 + depends on ISA && X86_32 default n ---help--- Linux uses the PNPBIOS as defined in "Plug and Play BIOS
The PNPBIOS driver requires preprocessor defines (located in include/asm/segment.h) only declared if the architecture is set to X86_32. If the architecture is set to X86_64, the PNPBIOS driver will not build properly. The X86 dependecy for the PNPBIOS configuration option is changed to an explicit X86_32 dependency in order to prevent an attempt to build for an unsupported architecture. Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/pnp/pnpbios/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)