diff mbox

[v2,3/3] MAINTAINERS: Add entry for Mali-DP driver

Message ID 1461593964-27722-4-git-send-email-Liviu.Dudau@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liviu Dudau April 25, 2016, 2:19 p.m. UTC
Add MAINTAINERS entry for ARM Mali-DP driver and update the
HDLCD file matching pattern to cover only HDLCD rather than
the whole drivers/gpu/drm/arm directory.

Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
 MAINTAINERS | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Emil Velikov April 25, 2016, 4 p.m. UTC | #1
On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> Add MAINTAINERS entry for ARM Mali-DP driver and update the
> HDLCD file matching pattern to cover only HDLCD rather than
> the whole drivers/gpu/drm/arm directory.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
>  MAINTAINERS | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d5b4be..a5a4346 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
>  ARM HDLCD DRM DRIVER
>  M:     Liviu Dudau <liviu.dudau@arm.com>
>  S:     Supported
> -F:     drivers/gpu/drm/arm/
> +F:     drivers/gpu/drm/arm/hdlcd_*
>  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
>
> +ARM MALI-DP DRM DRIVER
> +M:     Liviu Dudau <liviu.dudau@arm.com>
> +M:     Brian Starkey <brian.starkey@arm.com>
> +M:     Mali DP Maintainers <malidp@foss.arm.com>
> +S:     Supported
> +F:     drivers/gpu/drm/arm/
Woohoo. Thanks Liviu !

Note that having both drivers' sources in the same folder will cause
some grief wrt getting the correct maintainer. If you want to avoid
that the easiest way is to move things in subdirectories roughly like:

drivers/gpu/arm/hdlcd/
drivers/gpu/arm/mapidp/

Regards,
Emil
Liviu Dudau April 25, 2016, 5:08 p.m. UTC | #2
On Mon, Apr 25, 2016 at 05:00:02PM +0100, Emil Velikov wrote:
> On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> > Add MAINTAINERS entry for ARM Mali-DP driver and update the
> > HDLCD file matching pattern to cover only HDLCD rather than
> > the whole drivers/gpu/drm/arm directory.
> >
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > ---
> >  MAINTAINERS | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d5b4be..a5a4346 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
> >  ARM HDLCD DRM DRIVER
> >  M:     Liviu Dudau <liviu.dudau@arm.com>
> >  S:     Supported
> > -F:     drivers/gpu/drm/arm/
> > +F:     drivers/gpu/drm/arm/hdlcd_*
> >  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
> >
> > +ARM MALI-DP DRM DRIVER
> > +M:     Liviu Dudau <liviu.dudau@arm.com>
> > +M:     Brian Starkey <brian.starkey@arm.com>
> > +M:     Mali DP Maintainers <malidp@foss.arm.com>
> > +S:     Supported
> > +F:     drivers/gpu/drm/arm/
> Woohoo. Thanks Liviu !
> 
> Note that having both drivers' sources in the same folder will cause
> some grief wrt getting the correct maintainer. If you want to avoid
> that the easiest way is to move things in subdirectories roughly like:
> 
> drivers/gpu/arm/hdlcd/
> drivers/gpu/arm/mapidp/

I'm surprised to hear that there might be problems. All HDLCD files start
with hdlcd_ and the rest will go to the Mali-DP DRM maintainers (which includes
me as well).

I understand your suggestion and I thank for it, but I really hate to have
to navigate too many directories (for now). Lets see how things evolve and then
we can move stuff around.

Best regards,
Liviu


> 
> Regards,
> Emil
>
Emil Velikov April 25, 2016, 5:53 p.m. UTC | #3
On 25 April 2016 at 18:08, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> On Mon, Apr 25, 2016 at 05:00:02PM +0100, Emil Velikov wrote:
>> On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
>> > Add MAINTAINERS entry for ARM Mali-DP driver and update the
>> > HDLCD file matching pattern to cover only HDLCD rather than
>> > the whole drivers/gpu/drm/arm directory.
>> >
>> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>> > ---
>> >  MAINTAINERS | 10 +++++++++-
>> >  1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 1d5b4be..a5a4346 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
>> >  ARM HDLCD DRM DRIVER
>> >  M:     Liviu Dudau <liviu.dudau@arm.com>
>> >  S:     Supported
>> > -F:     drivers/gpu/drm/arm/
>> > +F:     drivers/gpu/drm/arm/hdlcd_*
>> >  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
>> >
>> > +ARM MALI-DP DRM DRIVER
>> > +M:     Liviu Dudau <liviu.dudau@arm.com>
>> > +M:     Brian Starkey <brian.starkey@arm.com>
>> > +M:     Mali DP Maintainers <malidp@foss.arm.com>
>> > +S:     Supported
>> > +F:     drivers/gpu/drm/arm/
>> Woohoo. Thanks Liviu !
>>
>> Note that having both drivers' sources in the same folder will cause
>> some grief wrt getting the correct maintainer. If you want to avoid
>> that the easiest way is to move things in subdirectories roughly like:
>>
>> drivers/gpu/arm/hdlcd/
>> drivers/gpu/arm/mapidp/
>
> I'm surprised to hear that there might be problems. All HDLCD files start
> with hdlcd_ and the rest will go to the Mali-DP DRM maintainers (which includes
> me as well).
>
You're absolutely right. I read things the wrong way - the MaliDP
maintainers will be added for the HDLCD patches. Which obviously isn't
the case.

> I understand your suggestion and I thank for it, but I really hate to have
> to navigate too many directories (for now). Lets see how things evolve and then
> we can move stuff around.
>
IIRC DRM had the same structure (all drivers living in a single a
folder) before 2008, before people got fed up.
Feel free to do as you wish, just pointing out some historical observations ;-)

Regardless of my suggestions/nitpicks, thanks for all the work Liviu !
It's really nice to see more vendors contributing to DRM.

Regards,
Emil
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d5b4be..a5a4346 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -850,9 +850,17 @@  F:	include/uapi/linux/if_arcnet.h
 ARM HDLCD DRM DRIVER
 M:	Liviu Dudau <liviu.dudau@arm.com>
 S:	Supported
-F:	drivers/gpu/drm/arm/
+F:	drivers/gpu/drm/arm/hdlcd_*
 F:	Documentation/devicetree/bindings/display/arm,hdlcd.txt
 
+ARM MALI-DP DRM DRIVER
+M:	Liviu Dudau <liviu.dudau@arm.com>
+M:	Brian Starkey <brian.starkey@arm.com>
+M:	Mali DP Maintainers <malidp@foss.arm.com>
+S:	Supported
+F:	drivers/gpu/drm/arm/
+F:	Documentation/devicetree/bindings/display/arm,malidp.txt
+
 ARM MFM AND FLOPPY DRIVERS
 M:	Ian Molton <spyro@f2s.com>
 S:	Maintained