| Message ID | 1461765754-19020-1-git-send-email-fabio.estevam@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/27/2016 04:02 PM, Fabio Estevam wrote: > According to ePAPR v1.1: "The unit-address must match the first address > specified in the reg property of the node" > > So do as recommended. Looks good, but if I may, I would suggest something more drastic. Would you instead remove the whole partitioning from the M28 DT? We always pass mtdparts from command line, so having some sort of default partitioning is quite pointless. Thanks for spotting this though, it's a good reminder to review older boards. > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi > index 759cc56..6270701 100644 > --- a/arch/arm/boot/dts/imx28-m28.dtsi > +++ b/arch/arm/boot/dts/imx28-m28.dtsi > @@ -34,22 +34,22 @@ > read-only; > }; > > - partition@1 { > + partition@300000 { > label = "environment"; > reg = <0x00300000 0x00080000>; > }; > > - partition@2 { > + partition@380000 { > label = "redundant-environment"; > reg = <0x00380000 0x00080000>; > }; > > - partition@3 { > + partition@400000 { > label = "kernel"; > reg = <0x00400000 0x00400000>; > }; > > - partition@4 { > + partition@800000 { > label = "filesystem"; > reg = <0x00800000 0x0f800000>; > }; >
diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi index 759cc56..6270701 100644 --- a/arch/arm/boot/dts/imx28-m28.dtsi +++ b/arch/arm/boot/dts/imx28-m28.dtsi @@ -34,22 +34,22 @@ read-only; }; - partition@1 { + partition@300000 { label = "environment"; reg = <0x00300000 0x00080000>; }; - partition@2 { + partition@380000 { label = "redundant-environment"; reg = <0x00380000 0x00080000>; }; - partition@3 { + partition@400000 { label = "kernel"; reg = <0x00400000 0x00400000>; }; - partition@4 { + partition@800000 { label = "filesystem"; reg = <0x00800000 0x0f800000>; };
According to ePAPR v1.1: "The unit-address must match the first address specified in the reg property of the node" So do as recommended. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)