Message ID | CAPcyv4g6431bUPLq3RpmoukHDeR3-n93FE=p85yhrC+gskYdjw@mail.gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 5/1/2016 8:33 PM, Dan Williams wrote: > Found it. This is one of those brown-paper-bag bugs that tells me I > need to figure out a way to unit/regression test the interface between > acpi_nfit_ctl() and acpi_evalaute_dsm(). In this case I injected a > __wrap_acpi_evaulate_dsm(), but I can't ship it as a new test in > nfit_test because it relies on an enabled BIOS for all the other > cases. Thanks. I'll give it a try. -- ljk > > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c > index d0f35e63640b..24ef312fdba3 100644 > --- a/drivers/acpi/nfit.c > +++ b/drivers/acpi/nfit.c > @@ -287,8 +288,11 @@ static int acpi_nfit_ctl(struct > nvdimm_bus_descriptor *nd_desc, > offset); > rc = -ENXIO; > } > - } else > + } else { > rc = 0; > + if (cmd_rc) > + *cmd_rc = xlat_status(buf, cmd); > + } > > out: > ACPI_FREE(out_obj); >
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c index d0f35e63640b..24ef312fdba3 100644 --- a/drivers/acpi/nfit.c +++ b/drivers/acpi/nfit.c @@ -287,8 +288,11 @@ static int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, offset); rc = -ENXIO; } - } else + } else { rc = 0; + if (cmd_rc) + *cmd_rc = xlat_status(buf, cmd); + } out: