Message ID | 1462791185-2903-6-git-send-email-hare@suse.de (mailing list archive) |
---|---|
State | Not Applicable, archived |
Delegated to: | Mike Snitzer |
Headers | show |
On Mon, May 09, 2016 at 12:53:03PM +0200, Hannes Reinecke wrote: > When calling 'cli_resume()' we should be waiting for udev to > ensure the device really has been resumed. Since multipathd has udev sync support disabled, this change doesn't do anything (which is fine, since I don't see any need to wait for udev here). It does allow your next patch to remove the need_sync option, which is (I assume) the bigger point. ACK -Ben > > Signed-off-by: Hannes Reinecke <hare@suse.com> > --- > multipathd/cli_handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c > index 0397353..5112786 100644 > --- a/multipathd/cli_handlers.c > +++ b/multipathd/cli_handlers.c > @@ -967,7 +967,7 @@ cli_resume(void * v, char ** reply, int * len, void * data) > return 1; > } > > - r = dm_simplecmd_noflush(DM_DEVICE_RESUME, param, 0, 0); > + r = dm_simplecmd_noflush(DM_DEVICE_RESUME, param, 1, 0); > > condlog(2, "%s: resume (operator)", param); > > -- > 2.6.6 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c index 0397353..5112786 100644 --- a/multipathd/cli_handlers.c +++ b/multipathd/cli_handlers.c @@ -967,7 +967,7 @@ cli_resume(void * v, char ** reply, int * len, void * data) return 1; } - r = dm_simplecmd_noflush(DM_DEVICE_RESUME, param, 0, 0); + r = dm_simplecmd_noflush(DM_DEVICE_RESUME, param, 1, 0); condlog(2, "%s: resume (operator)", param);
When calling 'cli_resume()' we should be waiting for udev to ensure the device really has been resumed. Signed-off-by: Hannes Reinecke <hare@suse.com> --- multipathd/cli_handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)