diff mbox

[maintainer-tools,v3] dim: Resist committing patches that modify files outside of i915

Message ID 1462870248-10425-1-git-send-email-joonas.lahtinen@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joonas Lahtinen May 10, 2016, 8:50 a.m. UTC
If committing to drm-intel-next-queued branch, require the committer
to be aware that they are committing outside of drm/i915 maintenance
scope.

v2:
- Do not use warn_or_fail (Jani)
- Only apply to drm-intel-next-queued branch (Daniel)

v3:
- Do not use HEAD but $commit (Jani)

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 dim | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Joonas Lahtinen May 10, 2016, 8:52 a.m. UTC | #1
Disregard this v3.

On ti, 2016-05-10 at 11:50 +0300, Joonas Lahtinen wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
> 
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to drm-intel-next-queued branch (Daniel)
> 
> v3:
> - Do not use HEAD but $commit (Jani)
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  dim | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/dim b/dim
> index d9c1be5..cbdae85 100755
> --- a/dim
> +++ b/dim
> @@ -691,6 +691,17 @@ function checkpatch_commit
>  	if test "$bug_lines" -eq 1; then
>  		warn_or_fail "New BUG macro added"
>  	fi
> +
> +        if [ "$branch" = "drm-intel-next-queued" ]; then
> +		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
> +			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
> +
> +		if [ -n "$non_i915_files" ]; then
> +			echo -e "The following files are outside of i915 maintenance scope:\n"
> +			echo "$non_i915_files"
> +			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
> +		fi
> +	fi
>  }
>  
>  # turn $1 in to a git commit range
diff mbox

Patch

diff --git a/dim b/dim
index d9c1be5..cbdae85 100755
--- a/dim
+++ b/dim
@@ -691,6 +691,17 @@  function checkpatch_commit
 	if test "$bug_lines" -eq 1; then
 		warn_or_fail "New BUG macro added"
 	fi
+
+        if [ "$branch" = "drm-intel-next-queued" ]; then
+		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
+			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
+
+		if [ -n "$non_i915_files" ]; then
+			echo -e "The following files are outside of i915 maintenance scope:\n"
+			echo "$non_i915_files"
+			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+		fi
+	fi
 }
 
 # turn $1 in to a git commit range