| Message ID | 1462924975-69072-2-git-send-email-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016/5/11 8:02, Brian Norris wrote: > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > though it's still not merged. > Hi Brain, I'm not sure whether it's acceptable to upstream new property which isn't merged yet. My major concern is that as the patchset supporting h400es will go through mmc tree, so if Ulf should want to shorten the name (e.g mmc-hs400-es), you would respin this patch. Thanks. > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > index 1a3eb1482050..ccfd2bcf02e1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > @@ -89,6 +89,18 @@ > status = "okay"; > }; > > +&emmc_phy { > + status = "okay"; > +}; > + > +&sdhci { > + bus-width = <8>; > + mmc-hs400-1_8v; > + non-removable; > + mmc-hs400-enhanced-strobe; > + status = "okay"; > +}; > + > &uart2 { > status = "okay"; > }; >
Hi, On Wed, May 11, 2016 at 08:59:24AM +0800, Shawn Lin wrote: > On 2016/5/11 8:02, Brian Norris wrote: > >The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > >though it's still not merged. > > > > Hi Brain, > > I'm not sure whether it's acceptable to upstream new property which > isn't merged yet. My major concern is that as the patchset supporting > h400es will go through mmc tree, so if Ulf should want to shorten the > name (e.g mmc-hs400-es), you would respin this patch. Well, Heiko can determine when to accept this. I wanted to post it to get things moving, but I can drop that property for now if it's going to cause difficulty. > Thanks. > > >Signed-off-by: Brian Norris <briannorris@chromium.org> > >--- BTW, I meant to note here that I haven't personally tested this EVB. I have tested other boards. This patch mostly serves the purpose of an example user, for my purposes. Brian > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > >diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >index 1a3eb1482050..ccfd2bcf02e1 100644 > >--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >@@ -89,6 +89,18 @@ > > status = "okay"; > > }; > > > >+&emmc_phy { > >+ status = "okay"; > >+}; > >+ > >+&sdhci { > >+ bus-width = <8>; > >+ mmc-hs400-1_8v; > >+ non-removable; > >+ mmc-hs400-enhanced-strobe; > >+ status = "okay"; > >+}; > >+ > > &uart2 { > > status = "okay"; > > }; > > > > > -- > Best Regards > Shawn Lin >
Hi Brian, Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > though it's still not merged. The commit message should describe the actual change not the volatile environment surrounding it :-) . When I apply this patch the property-binding will have made it into a maintainer-tree so is not valid anymore then. That is more material for the "comment-section" below the "---" > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index > 1a3eb1482050..ccfd2bcf02e1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > @@ -89,6 +89,18 @@ > status = "okay"; > }; > > +&emmc_phy { > + status = "okay"; > +}; > + > +&sdhci { > + bus-width = <8>; > + mmc-hs400-1_8v; > + non-removable; > + mmc-hs400-enhanced-strobe; alphabetic ordering of properties please > + status = "okay"; > +}; > + > &uart2 { > status = "okay"; > };
On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote: > Hi Brian, > > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > > though it's still not merged. > > The commit message should describe the actual change not the volatile > environment surrounding it :-) . > > When I apply this patch the property-binding will have made it into a > maintainer-tree so is not valid anymore then. That is more material for the > "comment-section" below the "---" Of course. I think I just felt guilty without a commit message :) > > Signed-off-by: Brian Norris <briannorris@chromium.org> > > --- > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index > > 1a3eb1482050..ccfd2bcf02e1 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > @@ -89,6 +89,18 @@ > > status = "okay"; > > }; > > > > +&emmc_phy { > > + status = "okay"; > > +}; > > + > > +&sdhci { > > + bus-width = <8>; > > + mmc-hs400-1_8v; > > + non-removable; > > + mmc-hs400-enhanced-strobe; > > alphabetic ordering of properties please Will fix. Thanks, Brian > > + status = "okay"; > > +}; > > + > > &uart2 { > > status = "okay"; > > }; >
Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris: > On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote: > > Hi Brian, > > > > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob > > > Herring, > > > though it's still not merged. > > > > The commit message should describe the actual change not the volatile > > environment surrounding it :-) . > > > > When I apply this patch the property-binding will have made it into a > > maintainer-tree so is not valid anymore then. That is more material for > > the "comment-section" below the "---" > > Of course. I think I just felt guilty without a commit message :) I really prefer a (even simple) message being there - although I'm not as strict as Greg and Felipe ;-) , and in cases like this I think something like "enable the newly added emmc node on the rk3399 evaluation board" should be sufficient. Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index 1a3eb1482050..ccfd2bcf02e1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts @@ -89,6 +89,18 @@ status = "okay"; }; +&emmc_phy { + status = "okay"; +}; + +&sdhci { + bus-width = <8>; + mmc-hs400-1_8v; + non-removable; + mmc-hs400-enhanced-strobe; + status = "okay"; +}; + &uart2 { status = "okay"; };
The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, though it's still not merged. Signed-off-by: Brian Norris <briannorris@chromium.org> --- arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)