| Message ID | 1307875953.1859.6.camel@Tux (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e6b8480cdf27953c3d13e6e34dd075f8287b02f0 |
| Headers | show |
Hey, 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? Ah yes, that seems to be the correct one, platform_driver_register was removed. Not 100% sure if acked by or signed-off-by is appropriate here. Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> ~Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On ?, 2011-06-12 at 19:48 +0200, Maarten Lankhorst wrote: > Hey, > > 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > > <snip> > > > > Hi Maarten: > > It registered efifb_device but try to unregistered efifb_driver, > > so I think you should fix it like this? > Ah yes, that seems to be the correct one, platform_driver_register was > removed. Not 100% sure if acked by or signed-off-by is appropriate > here. I think signed-off-by is OK. > > Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> > > ~Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/12/2011 06:52 AM, wanlong.gao wrote: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? > > Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > --- > drivers/video/efifb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > index 69c49df..784139a 100644 > --- a/drivers/video/efifb.c > +++ b/drivers/video/efifb.c > @@ -541,7 +541,7 @@ static int __init efifb_init(void) > */ > ret = platform_driver_probe(&efifb_driver, efifb_probe); > if (ret) { > - platform_device_unregister(&efifb_driver); > + platform_device_unregister(&efifb_device); > return ret; > } > Acked-by: Andy Lutomirski <luto@mit.edu> That's my bug. Sorry. I'm not sure why it compiled, though. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andy, 2011/6/13 Andy Lutomirski <luto@mit.edu>: > On 06/12/2011 06:52 AM, wanlong.gao wrote: >> >> <snip> >> >> Hi Maarten: >> It registered efifb_device but try to unregistered efifb_driver, >> so I think you should fix it like this? >> >> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> >> --- >> drivers/video/efifb.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c >> index 69c49df..784139a 100644 >> --- a/drivers/video/efifb.c >> +++ b/drivers/video/efifb.c >> @@ -541,7 +541,7 @@ static int __init efifb_init(void) >> */ >> ret = platform_driver_probe(&efifb_driver, efifb_probe); >> if (ret) { >> - platform_device_unregister(&efifb_driver); >> + platform_device_unregister(&efifb_device); >> return ret; >> } >> > > Acked-by: Andy Lutomirski <luto@mit.edu> > > That's my bug. Sorry. I'm not sure why it compiled, though. It compiled, but threw a warning. :) ~Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote: > On 06/12/2011 06:52 AM, wanlong.gao wrote: > ><snip> > > > >Hi Maarten: > >It registered efifb_device but try to unregistered efifb_driver, > >so I think you should fix it like this? > > > >Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > >--- > > drivers/video/efifb.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > >index 69c49df..784139a 100644 > >--- a/drivers/video/efifb.c > >+++ b/drivers/video/efifb.c > >@@ -541,7 +541,7 @@ static int __init efifb_init(void) > > */ > > ret = platform_driver_probe(&efifb_driver, efifb_probe); > > if (ret) { > >- platform_device_unregister(&efifb_driver); > >+ platform_device_unregister(&efifb_device); > > return ret; > > } > > > > Acked-by: Andy Lutomirski <luto@mit.edu> > Updated version applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; }
<snip> Hi Maarten: It registered efifb_device but try to unregistered efifb_driver, so I think you should fix it like this? Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com> --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)