| Message ID | 1463649727-18510-1-git-send-email-van.freenix@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Peng, On 19/05/16 10:22, Peng Fan wrote: > CPU0 boots up secondary CPUs one by one. Before booting > one secondary CPU, CPU0 will assign hwid to smp_up_cpu > and flush cache. After the secondary CPU boots up, NIT: s/the/a/ > CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush > cache. > > There is no need for secondary CPUs to assign MPIDR_INVALID > to smp_up_cpu. So, drop it. > > Signed-off-by: Peng Fan <van.freenix@gmail.com> > Cc: Julien Grall <julien.grall@arm.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> Reviewed-by: Julien Grall <julien.grall@arm.com> Regards, > --- > xen/arch/arm/smpboot.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index c5109bf..6b3c157 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset, > smp_wmb(); > > /* Now report this CPU is up */ > - smp_up_cpu = MPIDR_INVALID; > cpumask_set_cpu(cpuid, &cpu_online_map); > smp_wmb(); > >
On Thu, 19 May 2016, Julien Grall wrote: > Hi Peng, > > On 19/05/16 10:22, Peng Fan wrote: > > CPU0 boots up secondary CPUs one by one. Before booting > > one secondary CPU, CPU0 will assign hwid to smp_up_cpu > > and flush cache. After the secondary CPU boots up, > > NIT: s/the/a/ > > > CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush > > cache. > > > > There is no need for secondary CPUs to assign MPIDR_INVALID > > to smp_up_cpu. So, drop it. > > > > Signed-off-by: Peng Fan <van.freenix@gmail.com> > > Cc: Julien Grall <julien.grall@arm.com> > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > Reviewed-by: Julien Grall <julien.grall@arm.com> This is a cleanup, no need to commit it now. I'll add it to the 4.8 branch. > > > --- > > xen/arch/arm/smpboot.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > > index c5109bf..6b3c157 100644 > > --- a/xen/arch/arm/smpboot.c > > +++ b/xen/arch/arm/smpboot.c > > @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset, > > smp_wmb(); > > > > /* Now report this CPU is up */ > > - smp_up_cpu = MPIDR_INVALID; > > cpumask_set_cpu(cpuid, &cpu_online_map); > > smp_wmb(); > > > > > > -- > Julien Grall >
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index c5109bf..6b3c157 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset, smp_wmb(); /* Now report this CPU is up */ - smp_up_cpu = MPIDR_INVALID; cpumask_set_cpu(cpuid, &cpu_online_map); smp_wmb();
CPU0 boots up secondary CPUs one by one. Before booting one secondary CPU, CPU0 will assign hwid to smp_up_cpu and flush cache. After the secondary CPU boots up, CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush cache. There is no need for secondary CPUs to assign MPIDR_INVALID to smp_up_cpu. So, drop it. Signed-off-by: Peng Fan <van.freenix@gmail.com> Cc: Julien Grall <julien.grall@arm.com> Cc: Stefano Stabellini <sstabellini@kernel.org> --- xen/arch/arm/smpboot.c | 1 - 1 file changed, 1 deletion(-)