diff mbox

[2/4] drm/i915: Rename intel_shared_dpll_commit() to _swap_state()

Message ID 1463756065-11082-2-git-send-email-ander.conselvan.de.oliveira@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ander Conselvan de Oliveira May 20, 2016, 2:54 p.m. UTC
The function intel_shared_dpll_commit() performs the equivalent of
drm_atomic_helper_swap_state() for the shared dpll state, which id not
handled by the helpers. So rename it for consistency.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c  | 2 +-
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
 drivers/gpu/drm/i915/intel_dpll_mgr.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

durgadoss.r@intel.com May 23, 2016, 6:39 a.m. UTC | #1
> -----Original Message-----

> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf

> Of Ander Conselvan de Oliveira

> Sent: Friday, May 20, 2016 8:24 PM

> To: intel-gfx@lists.freedesktop.org

> Cc: Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>

> Subject: [Intel-gfx] [PATCH 2/4] drm/i915: Rename

> intel_shared_dpll_commit() to _swap_state()

> 

> The function intel_shared_dpll_commit() performs the equivalent of

> drm_atomic_helper_swap_state() for the shared dpll state, which id not


s/id/is

> handled by the helpers. So rename it for consistency.

> 


Reviewed-by: Durgadoss R <durgadoss.r@intel.com>


Thanks,
Durga

> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

> ---

>  drivers/gpu/drm/i915/intel_display.c  | 2 +-

>  drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-

>  drivers/gpu/drm/i915/intel_dpll_mgr.h | 2 +-

>  3 files changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/i915/intel_display.c

> b/drivers/gpu/drm/i915/intel_display.c

> index fe9b00c..dbb982aa 100644

> --- a/drivers/gpu/drm/i915/intel_display.c

> +++ b/drivers/gpu/drm/i915/intel_display.c

> @@ -13006,7 +13006,7 @@ static int intel_atomic_commit(struct drm_device

> *dev,

>  	drm_atomic_helper_swap_state(dev, state);

>  	dev_priv->wm.distrust_bios_wm = false;

>  	dev_priv->wm.skl_results = intel_state->wm_results;

> -	intel_shared_dpll_commit(state);

> +	intel_shared_dpll_swap_state(state);

> 

>  	if (intel_state->modeset) {

>  		memcpy(dev_priv->min_pixclk, intel_state->min_pixclk,

> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c

> b/drivers/gpu/drm/i915/intel_dpll_mgr.c

> index a3293cf..27bbc46 100644

> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c

> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c

> @@ -228,7 +228,7 @@ intel_reference_shared_dpll(struct intel_shared_dpll

> *pll,

>  	shared_dpll[pll->id].crtc_mask |= 1 << crtc->pipe;

>  }

> 

> -void intel_shared_dpll_commit(struct drm_atomic_state *state)

> +void intel_shared_dpll_swap_state(struct drm_atomic_state *state)

>  {

>  	struct drm_i915_private *dev_priv = to_i915(state->dev);

>  	struct intel_shared_dpll_config *shared_dpll;

> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h

> b/drivers/gpu/drm/i915/intel_dpll_mgr.h

> index b93eed8..929ff7d 100644

> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.h

> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.h

> @@ -151,7 +151,7 @@ void intel_release_shared_dpll(struct intel_crtc *crtc,

>  void intel_prepare_shared_dpll(struct intel_crtc *crtc);

>  void intel_enable_shared_dpll(struct intel_crtc *crtc);

>  void intel_disable_shared_dpll(struct intel_crtc *crtc);

> -void intel_shared_dpll_commit(struct drm_atomic_state *state);

> +void intel_shared_dpll_swap_state(struct drm_atomic_state *state);

>  void intel_shared_dpll_init(struct drm_device *dev);

> 

> 

> --

> 2.5.5

> 

> _______________________________________________

> Intel-gfx mailing list

> Intel-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index fe9b00c..dbb982aa 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13006,7 +13006,7 @@  static int intel_atomic_commit(struct drm_device *dev,
 	drm_atomic_helper_swap_state(dev, state);
 	dev_priv->wm.distrust_bios_wm = false;
 	dev_priv->wm.skl_results = intel_state->wm_results;
-	intel_shared_dpll_commit(state);
+	intel_shared_dpll_swap_state(state);
 
 	if (intel_state->modeset) {
 		memcpy(dev_priv->min_pixclk, intel_state->min_pixclk,
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index a3293cf..27bbc46 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -228,7 +228,7 @@  intel_reference_shared_dpll(struct intel_shared_dpll *pll,
 	shared_dpll[pll->id].crtc_mask |= 1 << crtc->pipe;
 }
 
-void intel_shared_dpll_commit(struct drm_atomic_state *state)
+void intel_shared_dpll_swap_state(struct drm_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->dev);
 	struct intel_shared_dpll_config *shared_dpll;
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.h b/drivers/gpu/drm/i915/intel_dpll_mgr.h
index b93eed8..929ff7d 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.h
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.h
@@ -151,7 +151,7 @@  void intel_release_shared_dpll(struct intel_crtc *crtc,
 void intel_prepare_shared_dpll(struct intel_crtc *crtc);
 void intel_enable_shared_dpll(struct intel_crtc *crtc);
 void intel_disable_shared_dpll(struct intel_crtc *crtc);
-void intel_shared_dpll_commit(struct drm_atomic_state *state);
+void intel_shared_dpll_swap_state(struct drm_atomic_state *state);
 void intel_shared_dpll_init(struct drm_device *dev);