[v1,5/6] scripts: ensure monitor socket has SO_REUSEADDR set

Commit Message

Daniel P. Berrangé May 5, 2016, 2:27 p.m. UTC

If tests use a TCP based monitor socket, the connection will
go into a TIMED_WAIT state when the test exits. This will
randomly prevent the test from being re-run without a certain
time period. Set the SO_REUSEADDR flag on the socket to ensure
we can immediately re-run the tests
---
 scripts/qmp/qmp.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Amit Shah May 23, 2016, 7:34 a.m. UTC | #1

On (Thu) 05 May 2016 [15:27:59], Daniel P. Berrange wrote:
> If tests use a TCP based monitor socket, the connection will
> go into a TIMED_WAIT state when the test exits. This will
> randomly prevent the test from being re-run without a certain
> time period. Set the SO_REUSEADDR flag on the socket to ensure
> we can immediately re-run the tests

Missing sign-off.

		Amit

Patch

diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
index 2d0d926..62d3651 100644
--- a/scripts/qmp/qmp.py
+++ b/scripts/qmp/qmp.py
@@ -43,6 +43,7 @@  class QEMUMonitorProtocol:
         self._debug = debug
         self.__sock = self.__get_sock()
         if server:
+            self.__sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
             self.__sock.bind(self.__address)
             self.__sock.listen(1)