diff mbox

[v2,11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

Message ID 1463728214-13838-12-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit c9c3b7c3029d501402b5ac4817659d6e0a6f11f4
Headers show

Commit Message

Geert Uytterhoeven May 20, 2016, 7:10 a.m. UTC
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /regulator@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator@2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator@3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - No changes.
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Sergei Shtylyov May 20, 2016, 3:38 p.m. UTC | #1
Hello.

On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:

> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /regulator@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /regulator@2 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /regulator@3 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - No changes.
> ---
>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
[...]
> @@ -127,7 +127,7 @@
>  		};
>  	};
>
> -	i2c2: i2c@2 {
> +	i2c2: i2c2 {

    Not "i2c-2" as in the other patches?

>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		compatible = "i2c-gpio";

MBR, Sergei
Geert Uytterhoeven May 23, 2016, 12:52 p.m. UTC | #2
On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>> Warning (unit_address_vs_reg): Node /regulator@0 has a unit name, but no reg property
>> Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property
>> Warning (unit_address_vs_reg): Node /regulator@2 has a unit name, but no reg property
>> Warning (unit_address_vs_reg): Node /regulator@3 has a unit name, but no reg property
>> Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> v2:
>>   - No changes.
>> ---
>>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
>> b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
>> index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
>> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
>> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
>
> [...]
>>
>> @@ -127,7 +127,7 @@
>>                 };
>>         };
>>
>> -       i2c2: i2c@2 {
>> +       i2c2: i2c2 {
>
>    Not "i2c-2" as in the other patches?

Oops... Thanks for noticing!

Simon: Do you want me to repost the whole series once again, or
can you fix this up while applying?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman May 24, 2016, 12:13 a.m. UTC | #3
On Mon, May 23, 2016 at 02:52:20PM +0200, Geert Uytterhoeven wrote:
> On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> >> Warning (unit_address_vs_reg): Node /regulator@0 has a unit name, but no reg property
> >> Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property
> >> Warning (unit_address_vs_reg): Node /regulator@2 has a unit name, but no reg property
> >> Warning (unit_address_vs_reg): Node /regulator@3 has a unit name, but no reg property
> >> Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> v2:
> >>   - No changes.
> >> ---
> >>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> >> b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> >> index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
> >> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> >> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> >
> > [...]
> >>
> >> @@ -127,7 +127,7 @@
> >>                 };
> >>         };
> >>
> >> -       i2c2: i2c@2 {
> >> +       i2c2: i2c2 {
> >
> >    Not "i2c-2" as in the other patches?
> 
> Oops... Thanks for noticing!
> 
> Simon: Do you want me to repost the whole series once again, or
> can you fix this up while applying?

I'll just fix it up.
No need to repost for this.
Simon Horman May 24, 2016, 12:33 a.m. UTC | #4
On Tue, May 24, 2016 at 09:13:09AM +0900, Simon Horman wrote:
> On Mon, May 23, 2016 at 02:52:20PM +0200, Geert Uytterhoeven wrote:
> > On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > > On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
> > >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> > >> Warning (unit_address_vs_reg): Node /regulator@0 has a unit name, but no reg property
> > >> Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property
> > >> Warning (unit_address_vs_reg): Node /regulator@2 has a unit name, but no reg property
> > >> Warning (unit_address_vs_reg): Node /regulator@3 has a unit name, but no reg property
> > >> Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property
> > >>
> > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >> ---
> > >> v2:
> > >>   - No changes.
> > >> ---
> > >>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
> > >>  1 file changed, 6 insertions(+), 6 deletions(-)
> > >>
> > >> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > >> b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > >> index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
> > >> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > >> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > >
> > > [...]
> > >>
> > >> @@ -127,7 +127,7 @@
> > >>                 };
> > >>         };
> > >>
> > >> -       i2c2: i2c@2 {
> > >> +       i2c2: i2c2 {
> > >
> > >    Not "i2c-2" as in the other patches?
> > 
> > Oops... Thanks for noticing!
> > 
> > Simon: Do you want me to repost the whole series once again, or
> > can you fix this up while applying?
> 
> I'll just fix it up.
> No need to repost for this.

I have queued this up with the above hunk changed to the following.
Please check the resulting patch and let me know if I've messed things up
somehow.

@@ -127,7 +127,7 @@
 		};
 	};
 
-	i2c2: i2c@2 {
+	i2c2: i2c-2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "i2c-gpio";
Geert Uytterhoeven May 24, 2016, 7:37 a.m. UTC | #5
Hi Simon,

On Tue, May 24, 2016 at 2:33 AM, Simon Horman <horms@verge.net.au> wrote:
>> > >> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
>> > >> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts

> I have queued this up with the above hunk changed to the following.
> Please check the resulting patch and let me know if I've messed things up
> somehow.
>
> @@ -127,7 +127,7 @@
>                 };
>         };
>
> -       i2c2: i2c@2 {
> +       i2c2: i2c-2 {

Thanks, looks fine.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -28,12 +28,12 @@ 
 		stdout-path = &scifa1;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x20000000>;
 	};
 
-	reg_3p3v: regulator@0 {
+	reg_3p3v: regulator-3p3v {
 		compatible = "regulator-fixed";
 		regulator-name = "fixed-3.3V";
 		regulator-min-microvolt = <3300000>;
@@ -42,7 +42,7 @@ 
 		regulator-boot-on;
 	};
 
-	vcc_sdhi0: regulator@1 {
+	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 
 		regulator-name = "SDHI0 Vcc";
@@ -53,7 +53,7 @@ 
 		enable-active-high;
 	};
 
-	vccq_sdhi0: regulator@2 {
+	vccq_sdhi0: regulator-vccq-sdhi0 {
 		compatible = "regulator-gpio";
 
 		regulator-name = "SDHI0 VccQ";
@@ -69,7 +69,7 @@ 
 		enable-active-high;
 	};
 
-	reg_5p0v: regulator@3 {
+	reg_5p0v: regulator-5p0v {
 		compatible = "regulator-fixed";
 		regulator-name = "fixed-5.0V";
 		regulator-min-microvolt = <5000000>;
@@ -127,7 +127,7 @@ 
 		};
 	};
 
-	i2c2: i2c@2 {
+	i2c2: i2c2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "i2c-gpio";