diff mbox

fuse: Document that dentry is unused in getxattr

Message ID 1464175827-5546-1-git-send-email-agruenba@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Gruenbacher May 25, 2016, 11:30 a.m. UTC 
For consistency with the other filesystems, rename the dentry argument
to "unused" here.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/fuse/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carlos Maiolino May 26, 2016, 1:15 p.m. UTC | #1 
On Wed, May 25, 2016 at 01:30:27PM +0200, Andreas Gruenbacher wrote:
> For consistency with the other filesystems, rename the dentry argument
> to "unused" here.
> 

Make sense, you can add:

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
>  fs/fuse/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index b941905..5760e27 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1755,7 +1755,7 @@ static int fuse_setxattr(struct dentry *entry, const char *name,
>  	return err;
>  }
>  
> -static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode,
> +static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode,
>  			     const char *name, void *value, size_t size)
>  {
>  	struct fuse_conn *fc = get_fuse_conn(inode);
> -- 
> 2.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index b941905..5760e27 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1755,7 +1755,7 @@  static int fuse_setxattr(struct dentry *entry, const char *name,
 	return err;
 }
 
-static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode,
+static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode,
 			     const char *name, void *value, size_t size)
 {
 	struct fuse_conn *fc = get_fuse_conn(inode);