| Message ID | 1464091153-11057-1-git-send-email-berto@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/24/2016 05:59 AM, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia <berto@igalia.com> > --- > docs/throttle.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/docs/throttle.txt b/docs/throttle.txt > index 06ed9b3..b4431f6 100644 > --- a/docs/throttle.txt > +++ b/docs/throttle.txt > @@ -39,7 +39,7 @@ the parameters for both cases: > | throttling.bps-write | bps_wr | > |-----------------------+-----------------------| > > -It is possible to set limits for both IOPS and bps and the same time, > +It is possible to set limits for both IOPS and bps at the same time, > and for each case we can decide whether to have separate read and > write limits or not, but note that if iops-total is set then neither > iops-read nor iops-write can be set. The same applies to bps-total and > @@ -235,7 +235,7 @@ consider the following values: > - Water leaks from the bucket at a rate of 100 IOPS. > - Water can be added to the bucket at a rate of 2000 IOPS. > - The size of the bucket is 2000 x 60 = 120000 > - - If 'iops-total-max-length' is unset then the bucket size is 100. > + - If 'iops-total-max' is unset then the bucket size is 100. > > The bucket is initially empty, therefore water can be added until it's > full at a rate of 2000 IOPS (the burst rate). Once the bucket is full >
Applied to -trivial, thanks! /mjt
On 05/25/2016 07:11 AM, Eric Blake wrote: > On 05/24/2016 05:59 AM, Alberto Garcia wrote: >> Signed-off-by: Alberto Garcia <berto@igalia.com> >> --- >> docs/throttle.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> > >> >> diff --git a/docs/throttle.txt b/docs/throttle.txt >> index 06ed9b3..b4431f6 100644 >> --- a/docs/throttle.txt >> +++ b/docs/throttle.txt >> @@ -39,7 +39,7 @@ the parameters for both cases: >> | throttling.bps-write | bps_wr | >> |-----------------------+-----------------------| >> >> -It is possible to set limits for both IOPS and bps and the same time, >> +It is possible to set limits for both IOPS and bps at the same time, >> and for each case we can decide whether to have separate read and >> write limits or not, but note that if iops-total is set then neither >> iops-read nor iops-write can be set. The same applies to bps-total and >> @@ -235,7 +235,7 @@ consider the following values: >> - Water leaks from the bucket at a rate of 100 IOPS. >> - Water can be added to the bucket at a rate of 2000 IOPS. >> - The size of the bucket is 2000 x 60 = 120000 >> - - If 'iops-total-max-length' is unset then the bucket size is 100. >> + - If 'iops-total-max' is unset then the bucket size is 100. Sorry to brother, why the bucket size is 100 rather than 100 x 60? Thanks -Xie >> >> The bucket is initially empty, therefore water can be added until it's >> full at a rate of 2000 IOPS (the burst rate). Once the bucket is full >> >
On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote: >>> - Water leaks from the bucket at a rate of 100 IOPS. >>> - Water can be added to the bucket at a rate of 2000 IOPS. >>> - The size of the bucket is 2000 x 60 = 120000 >>> - - If 'iops-total-max-length' is unset then the bucket size is 100. >>> + - If 'iops-total-max' is unset then the bucket size is 100. > > Sorry to brother, why the bucket size is 100 rather than 100 x 60? Oh, that's because 'iops-total-max-length' can only be set if 'iops-total-max' is set as well. It's explained earlier in the document, maybe I should make it clear there as well. Michael, shall I send a new patch on top of my previous one or can the previous one be replaced? Berto
On 05/30/2016 06:00 PM, Alberto Garcia wrote: > On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote: >>>> - Water leaks from the bucket at a rate of 100 IOPS. >>>> - Water can be added to the bucket at a rate of 2000 IOPS. >>>> - The size of the bucket is 2000 x 60 = 120000 >>>> - - If 'iops-total-max-length' is unset then the bucket size is 100. >>>> + - If 'iops-total-max' is unset then the bucket size is 100. >> >> Sorry to brother, why the bucket size is 100 rather than 100 x 60? > > Oh, that's because 'iops-total-max-length' can only be set if > 'iops-total-max' is set as well. It's explained earlier in the document, > maybe I should make it clear there as well. Thanks for your explanation, Thanks -Xie > > Michael, shall I send a new patch on top of my previous one or can the > previous one be replaced? > > Berto > > >
30.05.2016 13:00, Alberto Garcia wrote: > On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote: >>>> - Water leaks from the bucket at a rate of 100 IOPS. >>>> - Water can be added to the bucket at a rate of 2000 IOPS. >>>> - The size of the bucket is 2000 x 60 = 120000 >>>> - - If 'iops-total-max-length' is unset then the bucket size is 100. >>>> + - If 'iops-total-max' is unset then the bucket size is 100. >> >> Sorry to brother, why the bucket size is 100 rather than 100 x 60? > > Oh, that's because 'iops-total-max-length' can only be set if > 'iops-total-max' is set as well. It's explained earlier in the document, > maybe I should make it clear there as well. > > Michael, shall I send a new patch on top of my previous one or can the > previous one be replaced? I fixed it in the original commit, thanks! /mjt
diff --git a/docs/throttle.txt b/docs/throttle.txt index 06ed9b3..b4431f6 100644 --- a/docs/throttle.txt +++ b/docs/throttle.txt @@ -39,7 +39,7 @@ the parameters for both cases: | throttling.bps-write | bps_wr | |-----------------------+-----------------------| -It is possible to set limits for both IOPS and bps and the same time, +It is possible to set limits for both IOPS and bps at the same time, and for each case we can decide whether to have separate read and write limits or not, but note that if iops-total is set then neither iops-read nor iops-write can be set. The same applies to bps-total and @@ -235,7 +235,7 @@ consider the following values: - Water leaks from the bucket at a rate of 100 IOPS. - Water can be added to the bucket at a rate of 2000 IOPS. - The size of the bucket is 2000 x 60 = 120000 - - If 'iops-total-max-length' is unset then the bucket size is 100. + - If 'iops-total-max' is unset then the bucket size is 100. The bucket is initially empty, therefore water can be added until it's full at a rate of 2000 IOPS (the burst rate). Once the bucket is full
Signed-off-by: Alberto Garcia <berto@igalia.com> --- docs/throttle.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)