diff mbox

[v3,00/17] Xattr inode operation removal

Message ID CA+icZUVmB1pSuG1_3-nkiKjoDH9UrvUEsZjy8hS6_+Y2yDyruA@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sedat Dilek May 30, 2016, 12:56 p.m. UTC 
On 5/30/16, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> On Mon, May 30, 2016 at 11:54 AM, Sedat Dilek <sedat.dilek@gmail.com>
> wrote:
>> On 5/30/16, Andreas Gruenbacher <agruenba@redhat.com> wrote:
>>> This is version 3 of the xattr inode operation removal patch series. The
>>> patches are available in git form at:
>>>
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/agruen/linux.git/log/?h=work.xattr
> [...]
>>>
>> Hi,
>>
>> I pulled in agruen/linux.git#work.xattr on top of Linux v4.7-rc1 and
>> noticed...
>>
>>  92 files changed, 563 insertions(+), 703 deletions(-)
>>
>> So this is on top of Linux v4.7-rc1+?
>
> Well, I've actually rebased the patches on top of commit b02b1fbd
> which is the current mainline and one merge after v4.7-rc1, but the
> few scsi commits in between -rc1 and b02b1fbd are completely
> unrelated. You can easily see that in git.
>

I have seen the scsi changes when I ran my script which generates a
patchset where latest "git-tag in Linus tree" is the base, here
v4.7-rc1.

>> I am here on Ubuntu/precise AMD64 realized as a WUBI-installation.
>> So I use fuse, loop-device and ext4-fs.
>>
>> Not sure, how to test your patchset.
>> Can you give some instructions on a testcase/usecase?
>
> The patches potentially affect xattrs and anthing that's xattr based,
> like POSIX ACLs, SELinux, and Smack. There are some POSX ACL tests in
> xfstests. The basic xattr functionality can of course be checked with
> getfattr / setfattr. Other than that, I can probably only refer you to
> the code itself.
>

Here I have LTP v20160126 installed.

# cat /opt/ltp/Version
20160126

I ran acl_test01 (which I hacked a bit)...

# LC_ALL=C ./runltp -s acl_test01 | tee acl_test01.log

# cat results/LTP_RUN_ON-2016_05_30-14h_52m_29s.log
Test Start Time: Mon May 30 14:52:30 2016
-----------------------------------------
Testcase                       Result     Exit Value
--------                       ------     ----------
acl_test01                     PASS       0

-----------------------------------------------
Total Tests: 1
Total Skipped Tests: 0
Total Failures: 0
Kernel Version: 4.7.0-rc1-2-iniza-small
Machine Architecture: x86_64
Hostname: fambox

...and it looks good.

>> Booting into a kernel with your patchset looks fine to me - on the 1st
>> sight.
>
> Okay, thanks.
>

Cannot say if this helps you.

- Sedat -

P.S.: Hacking acl_test01

# diff -uprN ./testcases/bin/acl_test01.orig ./testcases/bin/acl_test01

- EOT -

Comments

Andreas Gruenbacher May 30, 2016, 6:22 p.m. UTC | #1 
On Mon, May 30, 2016 at 6:02 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> I contacted the LTP mailing-list on the acl_test01 issues - WIP.
>
> From the LTP-ML I got the impulse to test with the xattr testcase...
>
> root# cd /opt/ltp ; LC_ALL=C ./runltp -s xattr | tee xattr.log
>
> ...this fails only in the cgroup_xattr testcase.
> [...]

The test seems to try getting/setting an xattr named "trusted." (no
suffix). That's an invalid name; such invalid names are rejected since
commit 98e9cb571 "vfs: Distinguish between full xattr names and proper
prefixes" (v4.5-rc1).

Could you try removing that from the LTP test and rerun it?

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sedat Dilek May 30, 2016, 6:51 p.m. UTC | #2 
On 5/30/16, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> On Mon, May 30, 2016 at 6:02 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> I contacted the LTP mailing-list on the acl_test01 issues - WIP.
>>
>> From the LTP-ML I got the impulse to test with the xattr testcase...
>>
>> root# cd /opt/ltp ; LC_ALL=C ./runltp -s xattr | tee xattr.log
>>
>> ...this fails only in the cgroup_xattr testcase.
>> [...]
>
> The test seems to try getting/setting an xattr named "trusted." (no
> suffix). That's an invalid name; such invalid names are rejected since
> commit 98e9cb571 "vfs: Distinguish between full xattr names and proper
> prefixes" (v4.5-rc1).
>
> Could you try removing that from the LTP test and rerun it?
>

AFAICS I need to re-compile...

[ testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c ]
...
/* only security.* & trusted.* are valid key names */
static struct tst_key tkeys[] = {
        { .name = "security.",          .good = 1,      },
        { .name = "trusted.test",       .good = 1,      },
        { .name = "trusted.",           .good = 1,      }, <--- XXX:
This one only?
        { .name = "user.",              .good = 0,      },
        { .name = "system.",            .good = 0,      },
};
...

Which "trusted." line or lines shall I remove?

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- ./testcases/bin/acl_test01.orig     2016-03-27 21:45:00.768007420 +0200
+++ ./testcases/bin/acl_test01  2016-05-30 14:41:50.195986299 +0200
@@ -41,8 +41,6 @@  export TCID=acltest01
 export TST_TOTAL=5
 export TST_COUNT=1

-. test.sh
-
 TMP=${TMP:=/tmp}

 TEST_USER1="acltest1"
@@ -54,6 +52,8 @@  FILE_ACL="$TMP/tacl/mount-ext3/test_file
 FILE_ACL_LINK="$TMP/tacl/mount-ext3/test_file_link"
 TCbin=`pwd`

+. $TCbin/test.sh
+
 COMMAND=$(command -v "getenforce" "setenforce" |wc -l)
 if [ $COMMAND -eq 2 ]; then
        SELINUX=$(getenforce)