[net-next] ravb: Add ESF in RCR for enabling separation filter

Commit Message

Yoshihiro Kaneko May 29, 2016, 8:25 p.m. UTC

From: Masaru Nagai <[e-mail]>

This patch adds enabling separation filter(ESF) is setting value of B'11.
This setting filter for separating AVB stream frames from non-AVB stream
frames is enabled. Non-matching frames from a stream are processed in
queue 0(best effort). H/W manual recommends B'11 or B'10.
When B'10 is setting, Non-mating frames are discarded.

Signed-off-by: Masaru Nagai <[e-mail]>
Signed-off-by: Kazuya Mizuguchi <[e-mail]>
Signed-off-by: Yoshihiro Kaneko <[e-mail]>
---

This patch is based on the master branch of David Miller's next networking
tree.

 drivers/net/ethernet/renesas/ravb_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sergei Shtylyov May 30, 2016, 2:30 p.m. UTC | #1

On 05/29/2016 11:25 PM, Yoshihiro Kaneko wrote:

> From: Masaru Nagai <[e-mail]>
>
> This patch adds enabling separation filter(ESF) is setting value of B'11.
> This setting filter for separating AVB stream frames from non-AVB stream
> frames is enabled. Non-matching frames from a stream are processed in
> queue 0(best effort). H/W manual recommends B'11 or B'10.
> When B'10 is setting, Non-mating frames are discarded.

    It was somewhat hard for me to parse that...

> Signed-off-by: Masaru Nagai <[e-mail]>
> Signed-off-by: Kazuya Mizuguchi <[e-mail]>
> Signed-off-by: Yoshihiro Kaneko <[e-mail]>

Acked-by: Sergei Shtylyov <[e-mail]>

MBR, Sergei

Sergei Shtylyov May 30, 2016, 9:19 p.m. UTC | #2

On 05/30/2016 05:30 PM, Sergei Shtylyov wrote:

>> From: Masaru Nagai <[e-mail]>
>>
>> This patch adds enabling separation filter(ESF) is setting value of B'11.
>> This setting filter for separating AVB stream frames from non-AVB stream
>> frames is enabled. Non-matching frames from a stream are processed in
>> queue 0(best effort). H/W manual recommends B'11 or B'10.
>> When B'10 is setting, Non-mating frames are discarded.
>
>    It was somewhat hard for me to parse that...

    Forgot about s/Non-mating/Non-matching/.

>> Signed-off-by: Masaru Nagai <[e-mail]>
>> Signed-off-by: Kazuya Mizuguchi <[e-mail]>
>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>
> Acked-by: Sergei Shtylyov <[e-mail]>

MBR, Sergei

Yoshihiro Kaneko May 31, 2016, 4:28 p.m. UTC | #3

Hi Sergei,

2016-05-31 6:19 GMT+09:00 Sergei Shtylyov <[e-mail]>:
> On 05/30/2016 05:30 PM, Sergei Shtylyov wrote:
>
>>> From: Masaru Nagai <[e-mail]>
>>>
>>> This patch adds enabling separation filter(ESF) is setting value of B'11.
>>> This setting filter for separating AVB stream frames from non-AVB stream
>>> frames is enabled. Non-matching frames from a stream are processed in
>>> queue 0(best effort). H/W manual recommends B'11 or B'10.
>>> When B'10 is setting, Non-mating frames are discarded.
>>
>>
>>    It was somewhat hard for me to parse that...
>
>
>    Forgot about s/Non-mating/Non-matching/.

Thanks for your review.
I will revise the commit message.

Thanks,
kaneko

>
>
>>> Signed-off-by: Masaru Nagai <[e-mail]>
>>> Signed-off-by: Kazuya Mizuguchi <[e-mail]>
>>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>>
>>
>> Acked-by: Sergei Shtylyov <[e-mail]>
>
>
> MBR, Sergei
>

Patch

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 867caf6..1ceadbf 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -402,7 +402,8 @@  static int ravb_dmac_init(struct net_device *ndev)
 #endif
 
 	/* Set AVB RX */
-	ravb_write(ndev, RCR_EFFS | RCR_ENCF | RCR_ETS0 | 0x18000000, RCR);
+	ravb_write(ndev,
+		   RCR_EFFS | RCR_ENCF | RCR_ETS0 | RCR_ESF | 0x18000000, RCR);
 
 	/* Set FIFO size */
 	ravb_write(ndev, TGC_TQP_AVBMODE1 | 0x00222200, TGC);