| Message ID | 1464621262-26770-9-git-send-email-tn@semihalf.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 30, 2016 at 05:14:21PM +0200, Tomasz Nowicki wrote: > ACPI requires to run acpi_pci_{add|remove}_bus while new PCI bus is created. > This allows to do some ACPI-specific additional configuration, like > PCI hotplug slot enumeration. In order to fulfill these requirements, > we implement arch-specific pcibios_{add|remove}_bus calls > and call acpi_pci_{add|remove}_bus from there. > > Signed-off-by: Tomasz Nowicki <tn@semihalf.com> > --- > arch/arm64/kernel/pci.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Is there a reason why this has to be a standalone patch ? It is pretty much useless without patch 9 or I have stared at this series for too long. Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 336deef..3663be1 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -17,6 +17,7 @@ > #include <linux/mm.h> > #include <linux/of_pci.h> > #include <linux/of_platform.h> > +#include <linux/pci-acpi.h> > #include <linux/slab.h> > > /* > @@ -96,4 +97,15 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) > /* TODO: Should be revisited when implementing PCI on ACPI */ > return NULL; > } > + > +void pcibios_add_bus(struct pci_bus *bus) > +{ > + acpi_pci_add_bus(bus); > +} > + > +void pcibios_remove_bus(struct pci_bus *bus) > +{ > + acpi_pci_remove_bus(bus); > +} > + > #endif > -- > 1.9.1 >
On 02.06.2016 11:45, Lorenzo Pieralisi wrote: > On Mon, May 30, 2016 at 05:14:21PM +0200, Tomasz Nowicki wrote: >> ACPI requires to run acpi_pci_{add|remove}_bus while new PCI bus is created. >> This allows to do some ACPI-specific additional configuration, like >> PCI hotplug slot enumeration. In order to fulfill these requirements, >> we implement arch-specific pcibios_{add|remove}_bus calls >> and call acpi_pci_{add|remove}_bus from there. >> >> Signed-off-by: Tomasz Nowicki <tn@semihalf.com> >> --- >> arch/arm64/kernel/pci.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > Is there a reason why this has to be a standalone patch ? No there is no good reason behind this I will squash it with 9. > > It is pretty much useless without patch 9 or I have stared at > this series for too long. Yes, it is useless w/o patch 9. > > Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Thanks, Tomasz
diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c index 336deef..3663be1 100644 --- a/arch/arm64/kernel/pci.c +++ b/arch/arm64/kernel/pci.c @@ -17,6 +17,7 @@ #include <linux/mm.h> #include <linux/of_pci.h> #include <linux/of_platform.h> +#include <linux/pci-acpi.h> #include <linux/slab.h> /* @@ -96,4 +97,15 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) /* TODO: Should be revisited when implementing PCI on ACPI */ return NULL; } + +void pcibios_add_bus(struct pci_bus *bus) +{ + acpi_pci_add_bus(bus); +} + +void pcibios_remove_bus(struct pci_bus *bus) +{ + acpi_pci_remove_bus(bus); +} + #endif
ACPI requires to run acpi_pci_{add|remove}_bus while new PCI bus is created. This allows to do some ACPI-specific additional configuration, like PCI hotplug slot enumeration. In order to fulfill these requirements, we implement arch-specific pcibios_{add|remove}_bus calls and call acpi_pci_{add|remove}_bus from there. Signed-off-by: Tomasz Nowicki <tn@semihalf.com> --- arch/arm64/kernel/pci.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)