diff mbox

spapr_pci: Drop cannot_instantiate_with_device_add_yet=false

Message ID 1464959074-15841-1-git-send-email-armbru@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Markus Armbruster June 3, 2016, 1:04 p.m. UTC
It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
enable adding PHB via -device".

Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ppc/spapr_pci.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alexey Kardashevskiy June 3, 2016, 1:28 p.m. UTC | #1
On 03/06/16 23:04, Markus Armbruster wrote:
> It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
> enable adding PHB via -device".
> 
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>




Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>



> ---
>  hw/ppc/spapr_pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 856aec7..18638dd 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1624,7 +1624,6 @@ static void spapr_phb_class_init(ObjectClass *klass, void *data)
>      dc->reset = spapr_phb_reset;
>      dc->vmsd = &vmstate_spapr_pci;
>      set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> -    dc->cannot_instantiate_with_device_add_yet = false;
>      hp->plug = spapr_phb_hot_plug_child;
>      hp->unplug = spapr_phb_hot_unplug_child;
>  }
>
David Gibson June 6, 2016, 1:20 a.m. UTC | #2
On Fri, Jun 03, 2016 at 11:28:08PM +1000, Alexey Kardashevskiy wrote:
> On 03/06/16 23:04, Markus Armbruster wrote:
> > It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
> > enable adding PHB via -device".
> > 
> > Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> 
> 
> 
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Applied to ppc-for-2.7, thanks.
diff mbox

Patch

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 856aec7..18638dd 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1624,7 +1624,6 @@  static void spapr_phb_class_init(ObjectClass *klass, void *data)
     dc->reset = spapr_phb_reset;
     dc->vmsd = &vmstate_spapr_pci;
     set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
-    dc->cannot_instantiate_with_device_add_yet = false;
     hp->plug = spapr_phb_hot_plug_child;
     hp->unplug = spapr_phb_hot_unplug_child;
 }