diff mbox

[1/6] vubr: remove false comment

Message ID 1465074321-22507-2-git-send-email-marcandre.lureau@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Marc-André Lureau June 4, 2016, 9:05 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

dispatcher_remove() is in use.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/vhost-user-bridge.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Markus Armbruster June 6, 2016, 7:34 a.m. UTC | #1 
marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> dispatcher_remove() is in use.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/vhost-user-bridge.c | 2 --
>  1 file changed, 2 deletions(-)

Suggest to change the title to

    tests/vhost-user-bridge: Remove false comment

or, if you really want to abbreviate

    tests/vubr: Remove false comment

to make it clear at a glance that this commit only touches tests.

Same for the other patches to this file.
Marc-André Lureau June 6, 2016, 10:16 a.m. UTC | #2 
Hi

----- Original Message -----
> marcandre.lureau@redhat.com writes:
> 
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > dispatcher_remove() is in use.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  tests/vhost-user-bridge.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Suggest to change the title to
> 
>     tests/vhost-user-bridge: Remove false comment

done, thanks
Victor Kaplansky June 6, 2016, 12:52 p.m. UTC | #3 
Thanks!
diff mbox

Patch

diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 0779ba2..7d548d8 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -104,8 +104,6 @@  dispatcher_add(Dispatcher *dispr, int sock, void *ctx, CallbackFunc cb)
     return 0;
 }
 
-/* dispatcher_remove() is not currently in use but may be useful
- * in the future. */
 static int
 dispatcher_remove(Dispatcher *dispr, int sock)
 {