| Message ID | 1465149621-4493-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d7d11005e9302fff3c50dd5193cf241ea41bba1 |
| Headers | show |
On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote: > m32r allmodconfig build is failing with the error: > ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! > > The code is using DMA but the related dependency is not mentioned in the > Kconfig. Rather than going through every single driver using DMA adding the dependency might it not be simpler to provide at least a stub DMA implementation for the architectures that don't have it?
On Monday 06 June 2016 11:17 AM, Mark Brown wrote: > On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote: >> m32r allmodconfig build is failing with the error: >> ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! >> >> The code is using DMA but the related dependency is not mentioned in the >> Kconfig. > > Rather than going through every single driver using DMA adding the > dependency might it not be simpler to provide at least a stub DMA > implementation for the architectures that don't have it? > Yes, i can add them for m32r. but since m32r is orphan i send all m32r patches to Andrew. So, Andrew, do you have any objection to it? Regards Sudip
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 06e099e..22aec9a 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -10,6 +10,7 @@ if SND_ATMEL_SOC config SND_ATMEL_SOC_PDC tristate + depends on HAS_DMA default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=y)
m32r allmodconfig build is failing with the error: ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! The code is using DMA but the related dependency is not mentioned in the Kconfig. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/134651165 sound/soc/atmel/Kconfig | 1 + 1 file changed, 1 insertion(+)