| Message ID | 1465386765-27867-1-git-send-email-ykk@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Yakir, On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote: > The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel > connected using eDP interfaces. > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > --- > Changes in v2: > - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 > > .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ > 1 file changed, 7 insertions(+) Seems sane to me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: > The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel > connected using eDP interfaces. > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > --- > Changes in v2: > - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 > > .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt > new file mode 100644 > index 0000000..81938c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt > @@ -0,0 +1,7 @@ > +Sharp 12.3" (2400x1600 pixels) TFT LCD panel > + > +Required properties: > +- compatible: should be "sharp,lq123p1jx31," ^ Need to drop the comma. No regulators or resets or pwms? Rob
Rob, On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote: > On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> --- >> Changes in v2: >> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >> >> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> new file mode 100644 >> index 0000000..81938c0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >> @@ -0,0 +1,7 @@ >> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "sharp,lq123p1jx31," > ^ > Need to drop the comma. Thanks for catching! > No regulators or resets or pwms? Could be more explicit I guess, but Yakir does say: > This binding is compatible with the simple-panel binding, which is specified > in simple-panel.txt in this directory. In that document it shows: Required properties: - power-supply: regulator to provide the supply voltage Optional properties: - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing - enable-gpios: GPIO pin to enable or disable the panel - backlight: phandle of the backlight device attached to the panel In general Yakir's bindings document match a huge chunk of the current existing bindings. Do this: cd Documentation/devicetree/bindings/display/panel grep -C20 "This binding is compatible with the simple-panel" * You'll find a huge chunk of files which are rather formulaic. It might make sense to just have one file and a list of panels which are simple panels? -Doug
On Fri, Jun 10, 2016 at 11:40 AM, Doug Anderson <dianders@chromium.org> wrote: > Rob, > > On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote: >> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >>> connected using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >>> --- >>> Changes in v2: >>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >>> >>> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> new file mode 100644 >>> index 0000000..81938c0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> @@ -0,0 +1,7 @@ >>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >>> + >>> +Required properties: >>> +- compatible: should be "sharp,lq123p1jx31," >> ^ >> Need to drop the comma. > > Thanks for catching! > >> No regulators or resets or pwms? > > Could be more explicit I guess, but Yakir does say: > >> This binding is compatible with the simple-panel binding, which is specified >> in simple-panel.txt in this directory. > > In that document it shows: > > Required properties: > - power-supply: regulator to provide the supply voltage > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > - enable-gpios: GPIO pin to enable or disable the panel > - backlight: phandle of the backlight device attached to the panel Ah yes, NM. > In general Yakir's bindings document match a huge chunk of the current > existing bindings. Do this: > cd Documentation/devicetree/bindings/display/panel > grep -C20 "This binding is compatible with the simple-panel" * > > You'll find a huge chunk of files which are rather formulaic. It > might make sense to just have one file and a list of panels which are > simple panels? If we're just documenting compatible strings, then maybe so. Rob
Hi, On Fri, Jun 10, 2016 at 10:54 AM, Rob Herring <robh@kernel.org> wrote: >> In general Yakir's bindings document match a huge chunk of the current >> existing bindings. Do this: >> cd Documentation/devicetree/bindings/display/panel >> grep -C20 "This binding is compatible with the simple-panel" * >> >> You'll find a huge chunk of files which are rather formulaic. It >> might make sense to just have one file and a list of panels which are >> simple panels? > > If we're just documenting compatible strings, then maybe so. I'm happy to post such a patch if folks would prefer. ...but since it's the kind of patch that is nearly certain to produce conflicts / miss in-flight patches, it might make sense for one of the maintainers of this directory write/post it at the most expedient time and manage transitions. I'm OK either way, so just let me know. Until that happens, I'd presume that the best course of action is to keep posting bindings using the current formulaic approach and to deviate as little as possible from the formula to make later unification easier. ;) Thanks! -Doug
On 06/11/2016 12:40 AM, Doug Anderson wrote: > Rob, > > On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote: >> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >>> connected using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >>> --- >>> Changes in v2: >>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >>> >>> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> new file mode 100644 >>> index 0000000..81938c0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> @@ -0,0 +1,7 @@ >>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >>> + >>> +Required properties: >>> +- compatible: should be "sharp,lq123p1jx31," >> ^ >> Need to drop the comma. > Thanks for catching! Done, > >> No regulators or resets or pwms? > Could be more explicit I guess, but Yakir does say: > >> This binding is compatible with the simple-panel binding, which is specified >> in simple-panel.txt in this directory. > In that document it shows: > > Required properties: > - power-supply: regulator to provide the supply voltage > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > - enable-gpios: GPIO pin to enable or disable the panel > - backlight: phandle of the backlight device attached to the panel > > > In general Yakir's bindings document match a huge chunk of the current > existing bindings. Do this: > cd Documentation/devicetree/bindings/display/panel > grep -C20 "This binding is compatible with the simple-panel" * > > You'll find a huge chunk of files which are rather formulaic. It > might make sense to just have one file and a list of panels which are > simple panels? > > > -Doug > > >
diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt new file mode 100644 index 0000000..81938c0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt @@ -0,0 +1,7 @@ +Sharp 12.3" (2400x1600 pixels) TFT LCD panel + +Required properties: +- compatible: should be "sharp,lq123p1jx31," + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel connected using eDP interfaces. Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- Changes in v2: - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt