| Message ID | 1463700017-18527-1-git-send-email-nm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Nishanth Menon <nm@ti.com> [160519 16:23]: > Enable Erratum 430973 similar to commit 5c86c5339c56 ("ARM: > omap2plus_defconfig: Enable ARM erratum 430973 for omap3") - Since > multiple defconfigs can exist from various points of view (multi_v7, > omap2plus etc.. it is always better to enable the erratum from the > Kconfig selection point of view so that downstream kernels dont have > to rediscover this all over again. This should safe to select now. Note that proc-v7.S still does not do anything with multiarch to configure it. So the bootloader still needs to enable it, or it needs to be done in the machine init like n900 does. So applying into omap-for-v4.7/fixes as it can solve some mysterious app crashers with armhf at least. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, Jun 09, 2016 at 12:15:13AM -0700, Tony Lindgren wrote: > * Nishanth Menon <nm@ti.com> [160519 16:23]: > > Enable Erratum 430973 similar to commit 5c86c5339c56 ("ARM: > > omap2plus_defconfig: Enable ARM erratum 430973 for omap3") - Since > > multiple defconfigs can exist from various points of view (multi_v7, > > omap2plus etc.. it is always better to enable the erratum from the > > Kconfig selection point of view so that downstream kernels dont have > > to rediscover this all over again. > > This should safe to select now. Note that proc-v7.S still does not > do anything with multiarch to configure it. So the bootloader still > needs to enable it, or it needs to be done in the machine init like > n900 does. mh I totally forgot about 430973. I still think [0] is the better solution. IIRC I never uploaded them to Russel's patchsystem, though :( [0] http://comments.gmane.org/gmane.linux.kernel/2002603 > So applying into omap-for-v4.7/fixes as it can solve some mysterious > app crashers with armhf at least. Only on N900 though: $ git grep ARM_ERRATA_430973 arch/arm/Kconfig:config ARM_ERRATA_430973 arch/arm/configs/axm55xx_defconfig:CONFIG_ARM_ERRATA_430973=y arch/arm/configs/omap2plus_defconfig:CONFIG_ARM_ERRATA_430973=y arch/arm/mach-omap2/board-rx51.c:#ifdef CONFIG_ARM_ERRATA_430973 arch/arm/mach-omap2/pdata-quirks.c: if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) { arch/arm/mm/proc-v7.S:#if defined(CONFIG_ARM_ERRATA_430973) && !defined(CONFIG_ARCH_MULTIPLATFORM) -- Sebastian
* Sebastian Reichel <sre@kernel.org> [160609 01:00]: > Hi, > > On Thu, Jun 09, 2016 at 12:15:13AM -0700, Tony Lindgren wrote: > > * Nishanth Menon <nm@ti.com> [160519 16:23]: > > > Enable Erratum 430973 similar to commit 5c86c5339c56 ("ARM: > > > omap2plus_defconfig: Enable ARM erratum 430973 for omap3") - Since > > > multiple defconfigs can exist from various points of view (multi_v7, > > > omap2plus etc.. it is always better to enable the erratum from the > > > Kconfig selection point of view so that downstream kernels dont have > > > to rediscover this all over again. > > > > This should safe to select now. Note that proc-v7.S still does not > > do anything with multiarch to configure it. So the bootloader still > > needs to enable it, or it needs to be done in the machine init like > > n900 does. > > mh I totally forgot about 430973. I still think [0] is the > better solution. IIRC I never uploaded them to Russel's > patchsystem, though :( > > [0] http://comments.gmane.org/gmane.linux.kernel/2002603 Sure makes sense to me. Meanwhile, Nishanth's patch prevents hitting the same issue over and over. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 415a0bd0cda6..e0c796060fa2 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -17,6 +17,7 @@ config ARCH_OMAP3 select PM_OPP if PM select PM if CPU_IDLE select SOC_HAS_OMAP2_SDRC + select ARM_ERRATA_430973 config ARCH_OMAP4 bool "TI OMAP4"
Enable Erratum 430973 similar to commit 5c86c5339c56 ("ARM: omap2plus_defconfig: Enable ARM erratum 430973 for omap3") - Since multiple defconfigs can exist from various points of view (multi_v7, omap2plus etc.. it is always better to enable the erratum from the Kconfig selection point of view so that downstream kernels dont have to rediscover this all over again. Reported-by: Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by: Nishanth Menon <nm@ti.com> --- Note: If this approach is fine, we should probably search and fixup errata enablement we have done directly in omap2plus_defconfig. arch/arm/mach-omap2/Kconfig | 1 + 1 file changed, 1 insertion(+)