| Message ID | 1465386768-27947-1-git-send-email-ykk@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Yakir, On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote: > The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected > using eDP interfaces. > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > --- > Changes in v2: > - Add detail timing of Sharp LQ123P1JX31 panel in v2 > > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) Looks good to me. Values in the table match the EDID I see from this panel and everything else looks to be in order. Reviewed-by: Doug Anderson <dianders@chromium.org> Tested-by: Doug Anderson <dianders@chromium.org>
Hi, On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote: > Yakir, > > On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote: >> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected >> using eDP interfaces. >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> --- >> Changes in v2: >> - Add detail timing of Sharp LQ123P1JX31 panel in v2 >> >> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) > > Looks good to me. Values in the table match the EDID I see from this > panel and everything else looks to be in order. > > Reviewed-by: Doug Anderson <dianders@chromium.org> > Tested-by: Doug Anderson <dianders@chromium.org> Sorry for not noticing. :( ...but as others have pointed out for your earlier patches, the size is incorrect. I found the correct size and it should be: .width = 259, .height = 173, -Doug
Doug, On 06/11/2016 12:11 AM, Doug Anderson wrote: > Hi, > > On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote: >> Yakir, >> >> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote: >>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected >>> using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >>> --- >>> Changes in v2: >>> - Add detail timing of Sharp LQ123P1JX31 panel in v2 >>> >>> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >> Looks good to me. Values in the table match the EDID I see from this >> panel and everything else looks to be in order. >> >> Reviewed-by: Doug Anderson <dianders@chromium.org> >> Tested-by: Doug Anderson <dianders@chromium.org> > Sorry for not noticing. :( ...but as others have pointed out for > your earlier patches, the size is incorrect. I found the correct size > and it should be: > > .width = 259, > .height = 173, > Ah, thanks, would correct it now :-D - Yakir > -Doug > > >
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 067a5c4..38b6660 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1314,6 +1314,29 @@ static const struct panel_desc samsung_ltn140at29_301 = { }, }; +static const struct drm_display_mode sharp_lq123p1jx31_mode = { + .clock = 252750, + .hdisplay = 2400, + .hsync_start = 2400 + 48, + .hsync_end = 2400 + 48 + 32, + .htotal = 2400 + 48 + 32 + 80, + .vdisplay = 1600, + .vsync_start = 1600 + 3, + .vsync_end = 1600 + 3 + 10, + .vtotal = 1600 + 3 + 10 + 33, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc sharp_lq123p1jx31 = { + .modes = &sharp_lq123p1jx31_mode, + .num_modes = 1, + .size = { + .width = 2400, + .height = 1600, + }, +}; + static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = { .clock = 33300, .hdisplay = 800, @@ -1537,6 +1560,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "samsung,ltn140at29-301", .data = &samsung_ltn140at29_301, }, { + .compatible = "sharp,lq123p1jx31", + .data = &sharp_lq123p1jx31, + }, { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, {
The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected using eDP interfaces. Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- Changes in v2: - Add detail timing of Sharp LQ123P1JX31 panel in v2 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)