diff mbox

[v2,20/22] target-arm/monitor.c: Advertise emulated GICv3 in capabilities

Message ID 1464274540-19693-21-git-send-email-peter.maydell@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Maydell May 26, 2016, 2:55 p.m. UTC 
Now we have an emulated GICv3 we should advertise it via the
capabilities in the monitor protocol.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/monitor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Shannon Zhao June 13, 2016, 11:40 a.m. UTC | #1 
On 2016/5/26 22:55, Peter Maydell wrote:
> Now we have an emulated GICv3 we should advertise it via the
> capabilities in the monitor protocol.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>

> ---
>  target-arm/monitor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target-arm/monitor.c b/target-arm/monitor.c
> index 1ee59a2..299cb80 100644
> --- a/target-arm/monitor.c
> +++ b/target-arm/monitor.c
> @@ -72,8 +72,7 @@ GICCapabilityList *qmp_query_gic_capabilities(Error **errp)
>      GICCapability *v2 = gic_cap_new(2), *v3 = gic_cap_new(3);
>  
>      v2->emulated = true;
> -    /* TODO: we'd change to true after we get emulated GICv3. */
> -    v3->emulated = false;
> +    v3->emulated = true;
>  
>      gic_cap_kvm_probe(v2, v3);
>  
>
diff mbox

Patch

diff --git a/target-arm/monitor.c b/target-arm/monitor.c
index 1ee59a2..299cb80 100644
--- a/target-arm/monitor.c
+++ b/target-arm/monitor.c
@@ -72,8 +72,7 @@  GICCapabilityList *qmp_query_gic_capabilities(Error **errp)
     GICCapability *v2 = gic_cap_new(2), *v3 = gic_cap_new(3);
 
     v2->emulated = true;
-    /* TODO: we'd change to true after we get emulated GICv3. */
-    v3->emulated = false;
+    v3->emulated = true;
 
     gic_cap_kvm_probe(v2, v3);