diff mbox

linux-user: add missing return in netlink switch statement

Message ID 1465909629-12698-1-git-send-email-laurent@vivier.eu (mailing list archive)
State New, archived
Headers show

Commit Message

Laurent Vivier June 14, 2016, 1:07 p.m. UTC 
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Maydell June 14, 2016, 1:14 p.m. UTC | #1 
On 14 June 2016 at 14:07, Laurent Vivier <laurent@vivier.eu> wrote:
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  linux-user/syscall.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 71ccbd9..0b937ca 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1688,6 +1688,7 @@ static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh,
>              struct nlmsgerr *e = NLMSG_DATA(nlh);
>              e->error = tswap32(e->error);
>              tswap_nlmsghdr(&e->msg);
> +            return 0;
>          }
>          default:
>              ret = target_to_host_nlmsg(nlh);
> --
> 2.5.5

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
diff mbox

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 71ccbd9..0b937ca 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1688,6 +1688,7 @@  static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh,
             struct nlmsgerr *e = NLMSG_DATA(nlh);
             e->error = tswap32(e->error);
             tswap_nlmsghdr(&e->msg);
+            return 0;
         }
         default:
             ret = target_to_host_nlmsg(nlh);