diff mbox

tests: Rename tests/Makefile to tests/Makefile.include

Message ID 1464747811-26917-1-git-send-email-famz@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fam Zheng June 1, 2016, 2:23 a.m. UTC
The file is only included from the top Makefile. Rename it to reflect
this more obviously.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 Makefile                             | 2 +-
 tests/{Makefile => Makefile.include} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tests/{Makefile => Makefile.include} (100%)

Comments

Eric Blake June 14, 2016, 10:05 p.m. UTC | #1
On 05/31/2016 08:23 PM, Fam Zheng wrote:
> The file is only included from the top Makefile. Rename it to reflect
> this more obviously.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  Makefile                             | 2 +-
>  tests/{Makefile => Makefile.include} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename tests/{Makefile => Makefile.include} (100%)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index 3a3c5dc..0cd111b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -161,7 +161,7 @@ dummy := $(call unnest-vars,, \
>                  common-obj-m)
>  
>  ifneq ($(wildcard config-host.mak),)
> -include $(SRC_PATH)/tests/Makefile
> +include $(SRC_PATH)/tests/Makefile.include
>  endif
>  
>  all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
> diff --git a/tests/Makefile b/tests/Makefile.include
> similarity index 100%
> rename from tests/Makefile
> rename to tests/Makefile.include
>
Fam Zheng June 15, 2016, 12:33 a.m. UTC | #2
On Tue, 06/14 16:05, Eric Blake wrote:
> On 05/31/2016 08:23 PM, Fam Zheng wrote:
> > The file is only included from the top Makefile. Rename it to reflect
> > this more obviously.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  Makefile                             | 2 +-
> >  tests/{Makefile => Makefile.include} | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename tests/{Makefile => Makefile.include} (100%)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

This one is already applied in master.

Fam
Eric Blake June 15, 2016, 1:41 a.m. UTC | #3
On 06/14/2016 06:33 PM, Fam Zheng wrote:
> On Tue, 06/14 16:05, Eric Blake wrote:
>> On 05/31/2016 08:23 PM, Fam Zheng wrote:
>>> The file is only included from the top Makefile. Rename it to reflect
>>> this more obviously.
>>>
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> ---
>>>  Makefile                             | 2 +-
>>>  tests/{Makefile => Makefile.include} | 0
>>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>>  rename tests/{Makefile => Makefile.include} (100%)
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> This one is already applied in master.
> 

Oh, shows how much I rely on tab-completion.
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 3a3c5dc..0cd111b 100644
--- a/Makefile
+++ b/Makefile
@@ -161,7 +161,7 @@  dummy := $(call unnest-vars,, \
                 common-obj-m)
 
 ifneq ($(wildcard config-host.mak),)
-include $(SRC_PATH)/tests/Makefile
+include $(SRC_PATH)/tests/Makefile.include
 endif
 
 all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
diff --git a/tests/Makefile b/tests/Makefile.include
similarity index 100%
rename from tests/Makefile
rename to tests/Makefile.include