| Message ID | 1465526889-8339-3-git-send-email-eblake@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Eric Blake <eblake@redhat.com> writes: > Maybe there should be; but until there is, we should not flag > strtod() calls as something to replaced with qemu_strtod(). > > We also lack qemu_strtof() and qemu_strtold(), but as no one > has been using strtof() or strtold(), it's not worth complicating > the regex for them. > > (Ironically, I had to use 'git commit -n' since checkpatch uses > TAB indents, in violation of its own recommendations.) > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c939a32..cf32c8f 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2453,7 +2453,7 @@ sub process { > } > > # recommend qemu_strto* over strto* for numeric conversions > - if ($line =~ /\b(strto[^k].*?)\s*\(/) { > + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { > WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); > } > # check for module_init(), use category-specific init macros explicitly please Reviewed-by: Markus Armbruster <armbru@redhat.com> Paolo, if you want me to smuggle this into master via qapi-next, let me know.
On 16/06/2016 18:20, Markus Armbruster wrote: > Eric Blake <eblake@redhat.com> writes: > >> Maybe there should be; but until there is, we should not flag >> strtod() calls as something to replaced with qemu_strtod(). >> >> We also lack qemu_strtof() and qemu_strtold(), but as no one >> has been using strtof() or strtold(), it's not worth complicating >> the regex for them. >> >> (Ironically, I had to use 'git commit -n' since checkpatch uses >> TAB indents, in violation of its own recommendations.) >> >> Signed-off-by: Eric Blake <eblake@redhat.com> >> --- >> scripts/checkpatch.pl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index c939a32..cf32c8f 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -2453,7 +2453,7 @@ sub process { >> } >> >> # recommend qemu_strto* over strto* for numeric conversions >> - if ($line =~ /\b(strto[^k].*?)\s*\(/) { >> + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { >> WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); >> } >> # check for module_init(), use category-specific init macros explicitly please > > Reviewed-by: Markus Armbruster <armbru@redhat.com> > > Paolo, if you want me to smuggle this into master via qapi-next, let me > know. Yes, please do. Paolo
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c939a32..cf32c8f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2453,7 +2453,7 @@ sub process { } # recommend qemu_strto* over strto* for numeric conversions - if ($line =~ /\b(strto[^k].*?)\s*\(/) { + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); } # check for module_init(), use category-specific init macros explicitly please
Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake <eblake@redhat.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)