| Message ID | 146612627940.12839.15145788608361492501.stgit@birch.djwong.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 16, 2016 at 06:17:59PM -0700, Darrick J. Wong wrote: > All the VFS functions in the dedupe ioctl path return int status, so > the ioctl handler ought to as well. > > Found by Coverity, CID 1350952. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> This should go out to Al as a separate patch. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 17, 2016 at 04:32:23AM -0700, Christoph Hellwig wrote: > On Thu, Jun 16, 2016 at 06:17:59PM -0700, Darrick J. Wong wrote: > > All the VFS functions in the dedupe ioctl path return int status, so > > the ioctl handler ought to as well. > > > > Found by Coverity, CID 1350952. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > This should go out to Al as a separate patch. I sent it to him back in February, though he hasn't responded. --D > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ioctl.c b/fs/ioctl.c index 116a333..db3d033 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp) return thaw_super(sb); } -static long ioctl_file_dedupe_range(struct file *file, void __user *arg) +static int ioctl_file_dedupe_range(struct file *file, void __user *arg) { struct file_dedupe_range __user *argp = arg; struct file_dedupe_range *same = NULL;
All the VFS functions in the dedupe ioctl path return int status, so the ioctl handler ought to as well. Found by Coverity, CID 1350952. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- fs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html